[llvm] [HLSL] Leave out entryname from string table for PSV versions < 3 (PR #191528)
Joshua Batista via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 12:53:18 PDT 2026
================
@@ -770,8 +770,11 @@ void DXContainerYAML::PSVInfo::mapInfoForVersion(yaml::IO &IO) {
IO.mapRequired("NumThreadsY", Info.NumThreadsY);
IO.mapRequired("NumThreadsZ", Info.NumThreadsZ);
- if (Version == 2)
+ if (Version == 2) {
+ if (!IO.outputting())
+ IO.mapOptional("EntryName", EntryName);
----------------
bob80905 wrote:
Without this, we wouldn't be able to construct the yaml test for PSV v2 (since there would be no concept of an EntryName field), so we wouldnt be able to construct a roundtrip test.
It's just for testing purposes, but we could return here.
But without this code we wouldn't be able to test that EntryName gets removed after converting back from obj to yaml.
https://github.com/llvm/llvm-project/pull/191528
More information about the llvm-commits
mailing list