[llvm] Fix missed 'else' in LVCodeViewReader and LVDWARFReader.cpp. (PR #188578)
Carlos Alberto Enciso via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 07:36:22 PDT 2026
CarlosAlbertoEnciso wrote:
> @CarlosAlbertoEnciso My apologies for this fail, thank you for reverting this change! Before committing I ran tests on msvc and, as it turned out, it allows to not specify ObjectYAML in CMakeLists.txt, but that doesn't work everywhere and linker fail. I reproduced the fail by using WSL and I made sure that adding ObjectYAML to theCMakeLists fix build. Do I need to recreate this PR with the addition of the dependency in CMake?
@Seraphimt No problem. A merged PR can't be reopened. You are correct.
You would need to recreate this one with the CMake changes.
https://github.com/llvm/llvm-project/pull/188578
More information about the llvm-commits
mailing list