[llvm] [SPIRV]Implementing PopCount for 16 and 64 bits (PR #191283)

[Steven Perron via llvm-commits]

=?utf-8?q?João?= Saffran <joaosaffranllvm at gmail.com>,Joao Saffran
 <joaosaffranllvm at gmail.com>,Joao Saffran <joaosaffranllvm at gmail.com>,Joao
 Saffran <joaosaffranllvm at gmail.com>,Joao Saffran <joaosaffranllvm at gmail.com>,Joao
 Saffran <joaosaffranllvm at gmail.com>,Joao Saffran <joaosaffranllvm at gmail.com>,Joao
 Saffran <joaosaffranllvm at gmail.com>,Joao Saffran <joaosaffranllvm at gmail.com>,Joao
 Saffran <joaosaffranllvm at gmail.com>,Joao Saffran <joaosaffranllvm at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/191283 at github.com>


https://github.com/s-perron approved this pull request.

LGTM. The only change I still would like is to add the vulkan env to the call to spirv-val so we do not accidentally generate code that is invalid for vulkan. I have a few comment so that you can avoid the linkage attribute. 

https://github.com/llvm/llvm-project/pull/191283