[llvm] [llvm][DebugInfo] formatv in GsymReader (PR #192000)

Konrad Kleine via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 03:31:07 PDT 2026


================
@@ -413,13 +414,13 @@ void GsymReader::dump(raw_ostream &OS) {
   OS << "INDEX  Offset\n";
   OS << "====== ==========\n";
   for (uint32_t I = 0; I < Header.NumAddresses; ++I)
-    OS << format("[%4u] ", I) << HEX32(AddrInfoOffsets[I]) << "\n";
+    OS << formatv("[{0,4}] ", I) << HEX32(AddrInfoOffsets[I]) << "\n";
----------------
kwk wrote:

I agree that formatv makes HEX32 and alike a bit superfluous. But they use different fixed widths for the hex strings. Those width are hard-coded. I think it is better to keep this as is, no?

https://github.com/llvm/llvm-project/pull/192000


More information about the llvm-commits mailing list