[llvm] [llvm][DebugInfo] formatv in DWARFExpressionPrinter (PR #191993)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 02:25:48 PDT 2026


================
@@ -142,22 +142,22 @@ static bool printOp(const DWARFExpression::Operation *Op, raw_ostream &OS,
         case 2:
         case 3: // global as uint32
         case 4:
-          OS << format(" 0x%" PRIx64, Op->getRawOperand(Operand));
+          OS << formatv(" {0:x}", Op->getRawOperand(Operand));
           break;
         default:
           assert(false);
         }
       } else if (Size == DWARFExpression::Operation::SizeBlock) {
         uint64_t Offset = Op->getRawOperand(Operand);
         for (unsigned i = 0; i < Op->getRawOperand(Operand - 1); ++i)
-          OS << format(" 0x%02x",
-                       static_cast<uint8_t>(Expr->getData()[Offset++]));
+          OS << formatv(" {0:x2}",
+                        static_cast<uint8_t>(Expr->getData()[Offset++]));
----------------
s-barannikov wrote:

The cast looks redundant, assuming operator[] returns char.

https://github.com/llvm/llvm-project/pull/191993


More information about the llvm-commits mailing list