[llvm] [AMDGPU] InstCombine: fold invalid calls to amdgcn intrinsics into poison values (PR #191904)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 13 15:51:39 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp b/llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp
index 03e9a0177..b85b46d32 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp
@@ -767,11 +767,10 @@ GCNTTIImpl::instCombineIntrinsic(InstCombiner &IC, IntrinsicInst &II) const {
case Intrinsic::amdgcn_workgroup_id_x:
case Intrinsic::amdgcn_workgroup_id_y:
case Intrinsic::amdgcn_workgroup_id_z: {
- StringRef Attr = IID == Intrinsic::amdgcn_workgroup_id_x
- ? "amdgpu-no-workgroup-id-x"
- : IID == Intrinsic::amdgcn_workgroup_id_y
- ? "amdgpu-no-workgroup-id-y"
- : "amdgpu-no-workgroup-id-z";
+ StringRef Attr =
+ IID == Intrinsic::amdgcn_workgroup_id_x ? "amdgpu-no-workgroup-id-x"
+ : IID == Intrinsic::amdgcn_workgroup_id_y ? "amdgpu-no-workgroup-id-y"
+ : "amdgpu-no-workgroup-id-z";
if (II.getFunction()->hasFnAttribute(Attr))
return IC.replaceInstUsesWith(II, PoisonValue::get(II.getType()));
return std::nullopt;
@@ -779,11 +778,10 @@ GCNTTIImpl::instCombineIntrinsic(InstCombiner &IC, IntrinsicInst &II) const {
case Intrinsic::amdgcn_workitem_id_x:
case Intrinsic::amdgcn_workitem_id_y:
case Intrinsic::amdgcn_workitem_id_z: {
- StringRef Attr = IID == Intrinsic::amdgcn_workitem_id_x
- ? "amdgpu-no-workitem-id-x"
- : IID == Intrinsic::amdgcn_workitem_id_y
- ? "amdgpu-no-workitem-id-y"
- : "amdgpu-no-workitem-id-z";
+ StringRef Attr =
+ IID == Intrinsic::amdgcn_workitem_id_x ? "amdgpu-no-workitem-id-x"
+ : IID == Intrinsic::amdgcn_workitem_id_y ? "amdgpu-no-workitem-id-y"
+ : "amdgpu-no-workitem-id-z";
if (II.getFunction()->hasFnAttribute(Attr))
return IC.replaceInstUsesWith(II, PoisonValue::get(II.getType()));
return std::nullopt;
@@ -796,11 +794,10 @@ GCNTTIImpl::instCombineIntrinsic(InstCombiner &IC, IntrinsicInst &II) const {
case Intrinsic::amdgcn_cluster_id_x:
case Intrinsic::amdgcn_cluster_id_y:
case Intrinsic::amdgcn_cluster_id_z: {
- StringRef Attr = IID == Intrinsic::amdgcn_cluster_id_x
- ? "amdgpu-no-cluster-id-x"
- : IID == Intrinsic::amdgcn_cluster_id_y
- ? "amdgpu-no-cluster-id-y"
- : "amdgpu-no-cluster-id-z";
+ StringRef Attr =
+ IID == Intrinsic::amdgcn_cluster_id_x ? "amdgpu-no-cluster-id-x"
+ : IID == Intrinsic::amdgcn_cluster_id_y ? "amdgpu-no-cluster-id-y"
+ : "amdgpu-no-cluster-id-z";
if (II.getFunction()->hasFnAttribute(Attr))
return IC.replaceInstUsesWith(II, PoisonValue::get(II.getType()));
return std::nullopt;
``````````
</details>
https://github.com/llvm/llvm-project/pull/191904
More information about the llvm-commits
mailing list