[llvm] [z/OS] Add z/OS archive reading support (PR #187110)

[James Henderson via llvm-commits]

================
@@ -368,6 +373,118 @@ Expected<uint64_t> BigArchiveMemberHeader::getSize() const {
   return *SizeOrErr + alignTo(*NameLenOrErr, 2);
 }
 
+template <std::size_t N>
+StringRef getFieldRawStringE2A(const char (&Field)[N], SmallString<64> &Dst) {
----------------
jh7370 wrote:

Don't abbreviate names unnecessarily. Without the context of the review, I wouldn't be able to guess that "E2A" means "ECBDICToASCII" (at least, I assume that's what it means). A shorter function name might be `ecbdicFieldToASCII`, if you feel `getFieldRawStringECBDICToASCII` is too verbose.

Also, should `Dst` be `SmallVectorImpl<char>`, to match the type used in `converToUTF8`? I don't think it's intended that `SmallString` be passed around as a parameter directly, presumably because of the size parameter overly restricting the function usage.

https://github.com/llvm/llvm-project/pull/187110