[llvm] [UniformityAnalysis] Add CallbackVH to keep UniformValues consistent on value deletion (PR #187658)

[Sameer Sahasrabuddhe via llvm-commits]

================
@@ -107,6 +143,15 @@ template <> void llvm::GenericUniformityAnalysisImpl<SSAContext>::initialize() {
     pushUsers(Arg);
 }
 
+template <>
+void llvm::GenericUniformityAnalysisImpl<SSAContext>::registerCallbacks() {
+  IRUniformValueCallbackManager *Manager =
+      new IRUniformValueCallbackManager(UniformValues);
+  for (const Value *V : UniformValues)
----------------
ssahasra wrote:

I am guessing the general idea is that we don't need to worry about the same issue occurring in a release build. Whoever is working on a Transform is expected to test a build with at least asserts enabled. 

https://github.com/llvm/llvm-project/pull/187658