[llvm] [AArch64][CostModel] Fix stale costs for "ctpop" Intrinsic (PR #191769)

via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 00:58:28 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp b/llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
index 9fb9758c9..9e0983f39 100644
--- a/llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
+++ b/llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
@@ -803,15 +803,11 @@ AArch64TTIImpl::getIntrinsicInstrCost(const IntrinsicCostAttributes &ICA,
       return getTypeLegalizationCost(RetTy).first * 12;
     }
     static const CostTblEntry CtpopCostTbl[] = {
-        {ISD::CTPOP, MVT::v2i64, 4},
-        {ISD::CTPOP, MVT::v4i32, 3},
-        {ISD::CTPOP, MVT::v8i16, 2},
-        {ISD::CTPOP, MVT::v16i8, 1},
-        {ISD::CTPOP, MVT::i64,   4},
-        {ISD::CTPOP, MVT::v2i32, 3},
-        {ISD::CTPOP, MVT::v4i16, 2},
-        {ISD::CTPOP, MVT::v8i8,  1},
-        {ISD::CTPOP, MVT::i32,   4},
+        {ISD::CTPOP, MVT::v2i64, 4}, {ISD::CTPOP, MVT::v4i32, 3},
+        {ISD::CTPOP, MVT::v8i16, 2}, {ISD::CTPOP, MVT::v16i8, 1},
+        {ISD::CTPOP, MVT::i64, 4},   {ISD::CTPOP, MVT::v2i32, 3},
+        {ISD::CTPOP, MVT::v4i16, 2}, {ISD::CTPOP, MVT::v8i8, 1},
+        {ISD::CTPOP, MVT::i32, 4},
     };
     EVT VT = TLI->getValueType(DL, RetTy, true);
     // i8 ctpop can avoid the uaddlv after cnt since only one byte is active,
@@ -822,11 +818,10 @@ AArch64TTIImpl::getIntrinsicInstrCost(const IntrinsicCostAttributes &ICA,
     auto LT = getTypeLegalizationCost(RetTy);
     MVT MTy = LT.second;
     if (const auto *Entry = CostTableLookup(CtpopCostTbl, ISD::CTPOP, MTy)) {
-      // Extra cost of +1 when illegal vector/scalar types are legalized by promoting
-      // the integer type.
-      int ExtraCost = MTy.getScalarSizeInBits() != RetTy->getScalarSizeInBits()
-                          ? 1
-                          : 0;
+      // Extra cost of +1 when illegal vector/scalar types are legalized by
+      // promoting the integer type.
+      int ExtraCost =
+          MTy.getScalarSizeInBits() != RetTy->getScalarSizeInBits() ? 1 : 0;
       return LT.first * Entry->Cost + ExtraCost;
     }
     break;

``````````

</details>


https://github.com/llvm/llvm-project/pull/191769


More information about the llvm-commits mailing list