[llvm] [NFC][LLVM] Rename IRBuilder/LLVM C API params for overload types (PR #191674)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 11 17:52:05 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-ir
Author: Rahul Joshi (jurahul)
<details>
<summary>Changes</summary>
Rename IRBuilder and LLVM C API function params for overload types to use names to better reflect their meaning.
---
Full diff: https://github.com/llvm/llvm-project/pull/191674.diff
4 Files Affected:
- (modified) llvm/include/llvm-c/Core.h (+12-12)
- (modified) llvm/include/llvm/IR/IRBuilder.h (+5-4)
- (modified) llvm/lib/IR/Core.cpp (+20-17)
- (modified) llvm/lib/IR/IRBuilder.cpp (+2-2)
``````````diff
diff --git a/llvm/include/llvm-c/Core.h b/llvm/include/llvm-c/Core.h
index 7f648dd53d9f7..86f636c636783 100644
--- a/llvm/include/llvm-c/Core.h
+++ b/llvm/include/llvm-c/Core.h
@@ -3147,25 +3147,25 @@ LLVM_C_ABI unsigned LLVMLookupIntrinsicID(const char *Name, size_t NameLen);
LLVM_C_ABI unsigned LLVMGetIntrinsicID(LLVMValueRef Fn);
/**
- * Get or insert the declaration of an intrinsic. For overloaded intrinsics,
- * parameter types must be provided to uniquely identify an overload.
+ * Get or insert the declaration of an intrinsic. For overloaded intrinsics,
+ * overload types must be provided to uniquely identify an overload.
*
* @see llvm::Intrinsic::getOrInsertDeclaration()
*/
LLVM_C_ABI LLVMValueRef LLVMGetIntrinsicDeclaration(LLVMModuleRef Mod,
unsigned ID,
- LLVMTypeRef *ParamTypes,
- size_t ParamCount);
+ LLVMTypeRef *OverloadTypes,
+ size_t OverloadCount);
/**
- * Retrieves the type of an intrinsic. For overloaded intrinsics, parameter
+ * Retrieves the type of an intrinsic. For overloaded intrinsics, overload
* types must be provided to uniquely identify an overload.
*
* @see llvm::Intrinsic::getType()
*/
LLVM_C_ABI LLVMTypeRef LLVMIntrinsicGetType(LLVMContextRef Ctx, unsigned ID,
- LLVMTypeRef *ParamTypes,
- size_t ParamCount);
+ LLVMTypeRef *OverloadTypes,
+ size_t OverloadCount);
/**
* Retrieves the name of an intrinsic.
@@ -3176,13 +3176,13 @@ LLVM_C_ABI const char *LLVMIntrinsicGetName(unsigned ID, size_t *NameLength);
/** Deprecated: Use LLVMIntrinsicCopyOverloadedName2 instead. */
LLVM_C_ABI char *LLVMIntrinsicCopyOverloadedName(unsigned ID,
- LLVMTypeRef *ParamTypes,
- size_t ParamCount,
+ LLVMTypeRef *OverloadTypes,
+ size_t OverloadCount,
size_t *NameLength);
/**
* Copies the name of an overloaded intrinsic identified by a given list of
- * parameter types.
+ * overload types.
*
* Unlike LLVMIntrinsicGetName, the caller is responsible for freeing the
* returned string.
@@ -3193,8 +3193,8 @@ LLVM_C_ABI char *LLVMIntrinsicCopyOverloadedName(unsigned ID,
*/
LLVM_C_ABI char *LLVMIntrinsicCopyOverloadedName2(LLVMModuleRef Mod,
unsigned ID,
- LLVMTypeRef *ParamTypes,
- size_t ParamCount,
+ LLVMTypeRef *OverloadTypes,
+ size_t OverloadCount,
size_t *NameLength);
/**
diff --git a/llvm/include/llvm/IR/IRBuilder.h b/llvm/include/llvm/IR/IRBuilder.h
index 4ed3d73c4a057..bdec42516b8cd 100644
--- a/llvm/include/llvm/IR/IRBuilder.h
+++ b/llvm/include/llvm/IR/IRBuilder.h
@@ -1011,10 +1011,11 @@ class IRBuilderBase {
Value *RHS, FMFSource FMFSource = {},
const Twine &Name = "");
- /// Create a call to intrinsic \p ID with \p Args, mangled using \p Types. If
- /// \p FMFSource is provided, copy fast-math-flags from that instruction to
- /// the intrinsic.
- LLVM_ABI CallInst *CreateIntrinsic(Intrinsic::ID ID, ArrayRef<Type *> Types,
+ /// Create a call to intrinsic \p ID with \p Args, mangled using
+ /// \p OverloadTypes. If \p FMFSource is provided, copy fast-math-flags from
+ /// that instruction to the intrinsic.
+ LLVM_ABI CallInst *CreateIntrinsic(Intrinsic::ID ID,
+ ArrayRef<Type *> OverloadTypes,
ArrayRef<Value *> Args,
FMFSource FMFSource = {},
const Twine &Name = "");
diff --git a/llvm/lib/IR/Core.cpp b/llvm/lib/IR/Core.cpp
index ba5d1c5c486d6..5e6b03d01b6ba 100644
--- a/llvm/lib/IR/Core.cpp
+++ b/llvm/lib/IR/Core.cpp
@@ -2552,13 +2552,13 @@ static Intrinsic::ID llvm_map_to_intrinsic_id(unsigned ID) {
return llvm::Intrinsic::ID(ID);
}
-LLVMValueRef LLVMGetIntrinsicDeclaration(LLVMModuleRef Mod,
- unsigned ID,
- LLVMTypeRef *ParamTypes,
- size_t ParamCount) {
- ArrayRef<Type*> Tys(unwrap(ParamTypes), ParamCount);
+LLVMValueRef LLVMGetIntrinsicDeclaration(LLVMModuleRef Mod, unsigned ID,
+ LLVMTypeRef *OverloadTypes,
+ size_t OverloadCount) {
+ ArrayRef<Type *> OverloadTys(unwrap(OverloadTypes), OverloadCount);
auto IID = llvm_map_to_intrinsic_id(ID);
- return wrap(llvm::Intrinsic::getOrInsertDeclaration(unwrap(Mod), IID, Tys));
+ return wrap(
+ llvm::Intrinsic::getOrInsertDeclaration(unwrap(Mod), IID, OverloadTys));
}
const char *LLVMIntrinsicGetName(unsigned ID, size_t *NameLength) {
@@ -2569,27 +2569,30 @@ const char *LLVMIntrinsicGetName(unsigned ID, size_t *NameLength) {
}
LLVMTypeRef LLVMIntrinsicGetType(LLVMContextRef Ctx, unsigned ID,
- LLVMTypeRef *ParamTypes, size_t ParamCount) {
+ LLVMTypeRef *OverloadTypes,
+ size_t OverloadCount) {
auto IID = llvm_map_to_intrinsic_id(ID);
- ArrayRef<Type*> Tys(unwrap(ParamTypes), ParamCount);
- return wrap(llvm::Intrinsic::getType(*unwrap(Ctx), IID, Tys));
+ ArrayRef<Type *> OverloadTys(unwrap(OverloadTypes), OverloadCount);
+ return wrap(llvm::Intrinsic::getType(*unwrap(Ctx), IID, OverloadTys));
}
-char *LLVMIntrinsicCopyOverloadedName(unsigned ID, LLVMTypeRef *ParamTypes,
- size_t ParamCount, size_t *NameLength) {
+char *LLVMIntrinsicCopyOverloadedName(unsigned ID, LLVMTypeRef *OverloadTypes,
+ size_t OverloadCount,
+ size_t *NameLength) {
auto IID = llvm_map_to_intrinsic_id(ID);
- ArrayRef<Type*> Tys(unwrap(ParamTypes), ParamCount);
- auto Str = llvm::Intrinsic::getNameNoUnnamedTypes(IID, Tys);
+ ArrayRef<Type *> OverloadTys(unwrap(OverloadTypes), OverloadCount);
+ auto Str = llvm::Intrinsic::getNameNoUnnamedTypes(IID, OverloadTys);
*NameLength = Str.length();
return strdup(Str.c_str());
}
char *LLVMIntrinsicCopyOverloadedName2(LLVMModuleRef Mod, unsigned ID,
- LLVMTypeRef *ParamTypes,
- size_t ParamCount, size_t *NameLength) {
+ LLVMTypeRef *OverloadTypes,
+ size_t OverloadCount,
+ size_t *NameLength) {
auto IID = llvm_map_to_intrinsic_id(ID);
- ArrayRef<Type *> Tys(unwrap(ParamTypes), ParamCount);
- auto Str = llvm::Intrinsic::getName(IID, Tys, unwrap(Mod));
+ ArrayRef<Type *> OverloadTys(unwrap(OverloadTypes), OverloadCount);
+ auto Str = llvm::Intrinsic::getName(IID, OverloadTys, unwrap(Mod));
*NameLength = Str.length();
return strdup(Str.c_str());
}
diff --git a/llvm/lib/IR/IRBuilder.cpp b/llvm/lib/IR/IRBuilder.cpp
index 4c6f2326fe149..8b8f8e68ee2b9 100644
--- a/llvm/lib/IR/IRBuilder.cpp
+++ b/llvm/lib/IR/IRBuilder.cpp
@@ -927,12 +927,12 @@ Value *IRBuilderBase::CreateBinaryIntrinsic(Intrinsic::ID ID, Value *LHS,
}
CallInst *IRBuilderBase::CreateIntrinsic(Intrinsic::ID ID,
- ArrayRef<Type *> Types,
+ ArrayRef<Type *> OverloadTypes,
ArrayRef<Value *> Args,
FMFSource FMFSource,
const Twine &Name) {
Module *M = BB->getModule();
- Function *Fn = Intrinsic::getOrInsertDeclaration(M, ID, Types);
+ Function *Fn = Intrinsic::getOrInsertDeclaration(M, ID, OverloadTypes);
return createCallHelper(Fn, Args, Name, FMFSource);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/191674
More information about the llvm-commits
mailing list