[llvm] [NFC] Replace `expectedToStdOptional` with `expectedToOptional` (PR #191359)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 139047 tests passed
* 2608 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Variable.cpp.o</summary>

```
FAILED: tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Variable.cpp.o
sccache /opt/llvm/bin/clang++ -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/source/Symbol -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Symbol -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/source -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Variable.cpp.o -MF tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Variable.cpp.o.d -o tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Variable.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Symbol/Variable.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Symbol/Variable.cpp:581:19: error: no member named 'expectedToStdOptional' in namespace 'llvm'; did you mean 'expectedToOptional'?
581 |         if (llvm::expectedToStdOptional(
|                   ^~~~~~~~~~~~~~~~~~~~~
|                   expectedToOptional
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Error.h:1117:40: note: 'expectedToOptional' declared here
1117 | template <typename T> std::optional<T> expectedToOptional(Expected<T> &&E) {
|                                        ^
1 error generated.
```
</details>
<details>
<summary>tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o</summary>

```
FAILED: tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o
sccache /opt/llvm/bin/clang++ -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/source/Plugins/TypeSystem/Clang -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Plugins/TypeSystem/Clang -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/source -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o -MF tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o.d -o tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6360:19: error: no member named 'expectedToStdOptional' in namespace 'llvm'; did you mean 'expectedToOptional'?
6360 |         if (llvm::expectedToStdOptional(base_class_clang_type.GetNumChildren(
|                   ^~~~~~~~~~~~~~~~~~~~~
|                   expectedToOptional
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Error.h:1117:40: note: 'expectedToOptional' declared here
1117 | template <typename T> std::optional<T> expectedToOptional(Expected<T> &&E) {
|                                        ^
1 error generated.
```
</details>
<details>
<summary>tools/lldb/source/ValueObject/CMakeFiles/lldbValueObject.dir/ValueObject.cpp.o</summary>

```
FAILED: tools/lldb/source/ValueObject/CMakeFiles/lldbValueObject.dir/ValueObject.cpp.o
sccache /opt/llvm/bin/clang++ -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/source/ValueObject -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/ValueObject -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/source -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/lldb/source/ValueObject/CMakeFiles/lldbValueObject.dir/ValueObject.cpp.o -MF tools/lldb/source/ValueObject/CMakeFiles/lldbValueObject.dir/ValueObject.cpp.o.d -o tools/lldb/source/ValueObject/CMakeFiles/lldbValueObject.dir/ValueObject.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/ValueObject/ValueObject.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/ValueObject/ValueObject.cpp:2525:23: error: no member named 'expectedToStdOptional' in namespace 'llvm'; did you mean 'expectedToOptional'?
2525 |                 llvm::expectedToStdOptional(
|                       ^~~~~~~~~~~~~~~~~~~~~
|                       expectedToOptional
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Error.h:1117:40: note: 'expectedToOptional' declared here
1117 | template <typename T> std::optional<T> expectedToOptional(Expected<T> &&E) {
|                                        ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/191359