[llvm] [AVX-512] Fix for disjoint-or-fold (VGF2P8AFFINEQB) (PR #190896)

Kartik Ohlan via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 7 19:56:19 PDT 2026


https://github.com/Ko496-glitch created https://github.com/llvm/llvm-project/pull/190896

Fixes #190502

1. Added implementation of helper 

```
 `static SDValue combineOrWithGF2P8AFFINEQB(SDNode *N, const SDLoc &DL,
                                           SelectionDAG &DAG, EVT VT)`
```

2. Wired the logic with combineOrXorWithSETCC

>From 1c3d7bff8f90b8510e792bea3f677b1d8acf06b9 Mon Sep 17 00:00:00 2001
From: kartikohlan <kartik7ohlan at gmail.com>
Date: Tue, 7 Apr 2026 22:48:39 -0400
Subject: [PATCH] Added helper combineOrWithGF2P8AFFINEQB

---
 llvm/lib/Target/X86/X86ISelLowering.cpp | 28 +++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index ebc8766969251..91b940fb8e31c 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -53171,6 +53171,31 @@ static SDValue combineAddOrSubToADCOrSBB(SDNode *N, const SDLoc &DL,
   return SDValue();
 }
 
+static SDValue combineOrWithGF2P8AFFINEQB(SDNode *N, const SDLoc &DL,
+                                          SelectionDAG &DAG, EVT VT) {
+  using namespace SDPatternMatch;
+  assert(N->getOpcode() == ISD::OR);
+
+  if (!N->getFlags().hasDisjoint() &&
+      !DAG.haveNoCommonBitsSet(N->getOperand(0), N->getOperand(1)))
+    return SDValue();
+
+  SDValue X, Y, SplatOp;
+  APInt Imm, SplatVal;
+  if (sd_match(N,
+               m_c_BinOp(ISD::OR,
+                         m_OneUse(m_TernaryOp(X86ISD::GF2P8AFFINEQB, m_Value(X),
+                                              m_Value(Y), m_ConstInt(Imm))),
+                         m_Value(SplatOp))) &&
+      X86::isConstantSplat(SplatOp, SplatVal, /*AllowPartialUndefs=*/false)) {
+    uint64_t NewImm = (Imm.getZExtValue() ^ SplatVal.getZExtValue()) & 0xFF;
+    return DAG.getNode(X86ISD::GF2P8AFFINEQB, DL, VT, X, Y,
+                       DAG.getTargetConstant(NewImm, DL, MVT::i8));
+  }
+
+  return SDValue();
+}
+
 static SDValue combineOrXorWithSETCC(unsigned Opc, const SDLoc &DL, EVT VT,
                                      SDValue N0, SDValue N1,
                                      SelectionDAG &DAG) {
@@ -53263,6 +53288,9 @@ static SDValue combineOr(SDNode *N, SelectionDAG &DAG,
                                                  DAG, DCI, Subtarget))
     return FPLogic;
 
+  if (SDValue R = combineOrWithGF2P8AFFINEQB(N, dl, DAG, VT))
+      return R;
+
   if (DCI.isBeforeLegalizeOps())
     return SDValue();
 



More information about the llvm-commits mailing list