[llvm] [bazel] Fix TestingSupport layering_check (PR #190630)

Keith Smiley via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 09:37:30 PDT 2026


https://github.com/keith created https://github.com/llvm/llvm-project/pull/190630

I'm not sure if this header is public API upstream but we are using it
that way anyways.


>From 7270f40abacbe89fde5c4f975998f8e41bc02991 Mon Sep 17 00:00:00 2001
From: Keith Smiley <keithbsmiley at gmail.com>
Date: Mon, 6 Apr 2026 09:36:48 -0700
Subject: [PATCH] [bazel] Fix TestingSupport layering_check

I'm not sure if this header is public API upstream but we are using it
that way anyways.
---
 utils/bazel/llvm-project-overlay/llvm/BUILD.bazel              | 2 --
 .../llvm-project-overlay/third-party/unittest/BUILD.bazel      | 3 ++-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
index 847a7e3a36feb..ce866a4ac0e3a 100644
--- a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -6471,10 +6471,8 @@ cc_library(
     ]),
     hdrs = glob(["include/llvm/Testing/Support/*.h"]),
     copts = llvm_copts,
-    features = ["-layering_check"],
     deps = [
         ":Support",
-        ":config",
         "//third-party/unittest:gmock",
         "//third-party/unittest:gtest",
     ],
diff --git a/utils/bazel/llvm-project-overlay/third-party/unittest/BUILD.bazel b/utils/bazel/llvm-project-overlay/third-party/unittest/BUILD.bazel
index 1ba1f6bd5a0e7..2800306145b13 100644
--- a/utils/bazel/llvm-project-overlay/third-party/unittest/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/third-party/unittest/BUILD.bazel
@@ -54,8 +54,9 @@ cc_library(
     ) + [
     ],
     hdrs = [
-        "googletest/include/gtest/gtest.h",
+        "googletest/include/gtest/gtest-printers.h",
         "googletest/include/gtest/gtest-spi.h",
+        "googletest/include/gtest/gtest.h",
         "googletest/include/gtest/internal/gtest-port.h",
     ],
     copts = llvm_copts,



More information about the llvm-commits mailing list