[llvm] [MathExtras] Optimize SaturatingAdd. Split it into two specialized parst and use reference instead pointer for owerflow flag (PR #190479)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 4 12:50:02 PDT 2026
github-actions[bot] wrote:
<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results
* 172147 tests passed
* 3106 tests skipped
* 1 test failed
## Failed Tests
(click on a test name to see its output)
### LLVM-Unit
<details>
<summary>LLVM-Unit.Support/_/SupportTests/MathExtras/SaturatingAdd</summary>
```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/unittests/Support/./SupportTests --gtest_filter=MathExtras.SaturatingAdd
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:261
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:265
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:269
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:273
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:285
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:289
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:261
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:265
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:269
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:273
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:285
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:289
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:261
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:265
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:269
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:273
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:285
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:289
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:261
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:265
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:269
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:273
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:285
Value of: ResultOverflowed
Actual: true
Expected: false
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Support/MathExtrasTest.cpp:289
Value of: ResultOverflowed
Actual: true
Expected: false
```
</details>
If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.
https://github.com/llvm/llvm-project/pull/190479
More information about the llvm-commits
mailing list