[llvm] [AMDGPU] Rename 1_5xVGPRs to 1536VGPRs to be more contextual. NFC (PR #190245)
Sirish Pande via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 2 12:55:20 PDT 2026
https://github.com/srpande created https://github.com/llvm/llvm-project/pull/190245
Renaming feature from 1_5xVGPRs to 1536VGPRs to to be more contextual.
>From bae6c4872c9f5b4c7e34a62759c3e7eb2250a471 Mon Sep 17 00:00:00 2001
From: Sirish Pande <Sirish.Pande at amd.com>
Date: Thu, 2 Apr 2026 14:41:33 -0500
Subject: [PATCH] [AMDGPU] Rename 1_5xVGPRs to 1536VGPRs to be more contextual.
NFC
---
llvm/lib/Target/AMDGPU/AMDGPU.td | 16 ++++++++--------
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp | 4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPU.td b/llvm/lib/Target/AMDGPU/AMDGPU.td
index e059582bc4720..8f87ab8cb7314 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPU.td
+++ b/llvm/lib/Target/AMDGPU/AMDGPU.td
@@ -1040,10 +1040,10 @@ defm NoDataDepHazard : AMDGPUSubtargetFeature<"no-data-dep-hazard",
/*GenPredicate=*/0
>;
-// Allocate 1536 VGPRs for wave32 and 768 VGPRs for wave64
+// 1536 physical VGPRs for wave32 and 768 VGPRs for wave64
// with allocation granularity 24 for wave32 and 12 for wave64
-defm 1_5xVGPRs : AMDGPUSubtargetFeature<"allocate1_5xvgprs",
- "Has 50% more physical VGPRs and 50% larger allocation granule",
+defm 1536VGPRs : AMDGPUSubtargetFeature<"1536-physical-vgprs",
+ "Has 1536 physical VGPRs per SIMD",
/*GenPredicate=*/0
>;
@@ -1919,12 +1919,12 @@ def FeatureISAVersion11_0_Common : FeatureSet<
def FeatureISAVersion11_0_0 : FeatureSet<
!listconcat(FeatureISAVersion11_0_Common.Features,
- [Feature1_5xVGPRs,
+ [Feature1536VGPRs,
FeatureUserSGPRInit16Bug])>;
def FeatureISAVersion11_0_1 : FeatureSet<
!listconcat(FeatureISAVersion11_0_Common.Features,
- [Feature1_5xVGPRs])>;
+ [Feature1536VGPRs])>;
def FeatureISAVersion11_0_2 : FeatureSet<
!listconcat(FeatureISAVersion11_0_Common.Features,
@@ -1949,7 +1949,7 @@ def FeatureISAVersion11_5_0 : FeatureSet<
def FeatureISAVersion11_5_1 : FeatureSet<
!listconcat(FeatureISAVersion11_5_Common.Features,
- [Feature1_5xVGPRs,
+ [Feature1536VGPRs,
FeaturePointSampleAccel])>;
def FeatureISAVersion11_5_2 : FeatureSet<
@@ -2013,7 +2013,7 @@ def FeatureISAVersion12 : FeatureSet<
FeatureScalarDwordx3Loads,
FeatureDPPSrc1SGPR,
FeatureMaxHardClauseLength32,
- Feature1_5xVGPRs,
+ Feature1536VGPRs,
FeatureMemoryAtomicFAddF32DenormalSupport,
FeatureBVHDualAndBVH8Insts,
FeatureWaitsBeforeSystemScopeStores,
@@ -2180,7 +2180,7 @@ def FeatureISAVersion13 : FeatureSet<
FeatureTanhInsts,
FeatureTensorCvtLutInsts,
FeatureTransposeLoadF4F6Insts,
- Feature1_5xVGPRs,
+ Feature1536VGPRs,
FeatureBF16TransInsts,
FeatureBF16ConversionInsts,
FeatureBF16PackedInsts,
diff --git a/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp b/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
index 749cead8a20fb..3ee19b905473b 100644
--- a/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
@@ -1427,7 +1427,7 @@ unsigned getVGPRAllocGranule(const MCSubtargetInfo *STI,
? *EnableWavefrontSize32
: STI->getFeatureBits().test(FeatureWavefrontSize32);
- if (STI->getFeatureBits().test(Feature1_5xVGPRs))
+ if (STI->getFeatureBits().test(Feature1536VGPRs))
return IsWave32 ? 24 : 12;
if (hasGFX10_3Insts(*STI))
@@ -1459,7 +1459,7 @@ unsigned getTotalNumVGPRs(const MCSubtargetInfo *STI) {
if (!isGFX10Plus(*STI))
return 256;
bool IsWave32 = STI->getFeatureBits().test(FeatureWavefrontSize32);
- if (STI->getFeatureBits().test(Feature1_5xVGPRs))
+ if (STI->getFeatureBits().test(Feature1536VGPRs))
return IsWave32 ? 1536 : 768;
return IsWave32 ? 1024 : 512;
}
More information about the llvm-commits
mailing list