[llvm] Allow DIBasicType (and others) to have a scope and location (PR #190217)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 61335 tests passed
* 1538 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] unittests/IR/CMakeFiles/IRTests.dir/DebugInfoTest.cpp.obj</summary>

```
FAILED: [code=1] unittests/IR/CMakeFiles/IRTests.dir/DebugInfoTest.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\unittests\IR -IC:\_work\llvm-project\llvm-project\llvm\unittests\IR -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG -Wno-gnu-zero-variadic-macro-arguments /EHs-c- /GR- -Wno-suggest-override /showIncludes /Founittests\IR\CMakeFiles\IRTests.dir\DebugInfoTest.cpp.obj /Fdunittests\IR\CMakeFiles\IRTests.dir\ -c -- C:\_work\llvm-project\llvm-project\llvm\unittests\IR\DebugInfoTest.cpp
C:\_work\llvm-project\llvm-project\llvm\unittests\IR\DebugInfoTest.cpp(529,66): error: too few arguments to function call, expected 9, have 6
528 |   DIFixedPointType *Ty = DIB.createBinaryFixedPointType(
|                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
529 |       {}, 32, 0, dwarf::DW_ATE_signed_fixed, DINode::FlagZero, -4);
|                                                                  ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/DIBuilder.h(255,5): note: 'createBinaryFixedPointType' declared here
255 |     createBinaryFixedPointType(StringRef Name, DIFile *File, unsigned LineNo,
|     ^                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
256 |                                DIScope *Context, uint64_t SizeInBits,
|                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
257 |                                uint32_t AlignInBits, unsigned Encoding,
|                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
258 |                                DINode::DIFlags Flags, int Factor);
|                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\unittests\IR\DebugInfoTest.cpp(537,60): error: too few arguments to function call, expected 9, have 6
536 |   Ty = DIB.createDecimalFixedPointType({}, 32, 0, dwarf::DW_ATE_unsigned_fixed,
|        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
537 |                                        DINode::FlagZero, -7);
|                                                            ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/DIBuilder.h(270,5): note: 'createDecimalFixedPointType' declared here
270 |     createDecimalFixedPointType(StringRef Name, DIFile *File, unsigned LineNo,
|     ^                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
271 |                                 DIScope *Context, uint64_t SizeInBits,
|                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
272 |                                 uint32_t AlignInBits, unsigned Encoding,
|                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
273 |                                 DINode::DIFlags Flags, int Factor);
|                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\unittests\IR\DebugInfoTest.cpp(547,69): error: too few arguments to function call, expected 10, have 7
546 |   Ty = DIB.createRationalFixedPointType({}, 32, 0, dwarf::DW_ATE_unsigned_fixed,
|        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
547 |                                         DINode::FlagZero, Num, Denom);
|                                                                     ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/DIBuilder.h(286,32): note: 'createRationalFixedPointType' declared here
286 |     LLVM_ABI DIFixedPointType *createRationalFixedPointType(
|                                ^
287 |         StringRef Name, DIFile *File, unsigned LineNo, DIScope *Context,
|         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
288 |         uint64_t SizeInBits, uint32_t AlignInBits, unsigned Encoding,
|         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
289 |         DINode::DIFlags Flags, APInt Numerator, APInt Denominator);
|         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/190217