[llvm] [AArch64][llvm] Some instructions should be `HINT` aliases (NFC) (PR #189926)

via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 01:35:01 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.h llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp b/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
index fdcce5eba..5d2c96848 100644
--- a/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
+++ b/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
@@ -2653,10 +2653,8 @@ public:
     return Op;
   }
 
-  static std::unique_ptr<AArch64Operand> CreateSHUHint(unsigned Val,
-                                                       StringRef Str,
-                                                       SMLoc S,
-                                                       MCContext &Ctx) {
+  static std::unique_ptr<AArch64Operand>
+  CreateSHUHint(unsigned Val, StringRef Str, SMLoc S, MCContext &Ctx) {
     auto Op = std::make_unique<AArch64Operand>(k_SHUHint, Ctx);
     Op->SHUHint.Val = Val + 50;
     Op->SHUHint.Data = Str.data();
@@ -2666,10 +2664,8 @@ public:
     return Op;
   }
 
-  static std::unique_ptr<AArch64Operand> CreateTSBHint(unsigned Val,
-                                                       StringRef Str,
-                                                       SMLoc S,
-                                                       MCContext &Ctx) {
+  static std::unique_ptr<AArch64Operand>
+  CreateTSBHint(unsigned Val, StringRef Str, SMLoc S, MCContext &Ctx) {
     auto Op = std::make_unique<AArch64Operand>(k_TSBHint, Ctx);
     Op->TSBHint.Val = Val | 16;
     Op->TSBHint.Data = Str.data();
@@ -4536,26 +4532,24 @@ AArch64AsmParser::tryParsePHintInstOperand(OperandVector &Operands) {
   return ParseStatus::Success;
 }
 
-ParseStatus
-AArch64AsmParser::tryParseSHUHintOperand(OperandVector &Operands) {
+ParseStatus AArch64AsmParser::tryParseSHUHintOperand(OperandVector &Operands) {
   SMLoc S = getLoc();
   const AsmToken &Tok = getTok();
   if (Tok.isNot(AsmToken::Identifier))
     return TokError("invalid operand for instruction");
 
-  auto SHU = AArch64CMHPriorityHint::lookupCMHPriorityHintByName(Tok.getString());
+  auto SHU =
+      AArch64CMHPriorityHint::lookupCMHPriorityHintByName(Tok.getString());
   if (!SHU)
     return TokError("invalid operand for instruction");
 
-  Operands.push_back(
-      AArch64Operand::CreateSHUHint(SHU->Encoding, Tok.getString(), S,
-                                    getContext()));
+  Operands.push_back(AArch64Operand::CreateSHUHint(
+      SHU->Encoding, Tok.getString(), S, getContext()));
   Lex(); // Eat identifier token.
   return ParseStatus::Success;
 }
 
-ParseStatus
-AArch64AsmParser::tryParseTSBHintOperand(OperandVector &Operands) {
+ParseStatus AArch64AsmParser::tryParseTSBHintOperand(OperandVector &Operands) {
   SMLoc S = getLoc();
   const AsmToken &Tok = getTok();
   if (Tok.isNot(AsmToken::Identifier))
@@ -4565,9 +4559,8 @@ AArch64AsmParser::tryParseTSBHintOperand(OperandVector &Operands) {
   if (!TSB || TSB->Encoding != AArch64TSB::csync)
     return TokError("'csync' operand expected");
 
-  Operands.push_back(
-      AArch64Operand::CreateTSBHint(TSB->Encoding, Tok.getString(), S,
-                                    getContext()));
+  Operands.push_back(AArch64Operand::CreateTSBHint(
+      TSB->Encoding, Tok.getString(), S, getContext()));
   Lex(); // Eat identifier token.
   return ParseStatus::Success;
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/189926


More information about the llvm-commits mailing list