[llvm] [X86][test] Add -combiner-topological-sorting to X86 CodeGen tests (NFC) (PR #189947)

Paweł Bylica via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 06:00:38 PDT 2026


chfast wrote:

Yes, I basically wanted to discuss current practices and work distribution and I don't know better place than issue or PR.

I'm guessing on first impressions you are not also interested in sending PRs documenting regressions in topological sorting. There are 10x less of these for x86 currently but still a lot.

I started looking at regressions related to carry propagation. I will try to send a DAG combiner change which handles one regression there. I just found the `// TODO: Just match ISD::ABDU once the DAG is topological sorted.` comment so I think I can apply the same approach if you think this is good.

https://github.com/llvm/llvm-project/pull/189947


More information about the llvm-commits mailing list