[llvm] [NFC][SPIR-V] Remove stale XFAIL for spec_const_decoration.ll (PR #189934)

Arseniy Obolenskiy via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 03:49:45 PDT 2026


https://github.com/aobolensk updated https://github.com/llvm/llvm-project/pull/189934

>From 88e580a044101f191bba98213042cbcab63e404e Mon Sep 17 00:00:00 2001
From: Arseniy Obolenskiy <arseniy.obolenskiy at amd.com>
Date: Wed, 1 Apr 2026 11:03:00 +0200
Subject: [PATCH 1/2] [NFC][SPIR-V] Remove stale XFAIL for
 spec_const_decoration.ll

The test no longer fails with expensive_checks enabled
---
 llvm/test/CodeGen/SPIRV/spec_const_decoration.ll | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/llvm/test/CodeGen/SPIRV/spec_const_decoration.ll b/llvm/test/CodeGen/SPIRV/spec_const_decoration.ll
index 2e3b1167ccdeb..a5d8b9962ac92 100644
--- a/llvm/test/CodeGen/SPIRV/spec_const_decoration.ll
+++ b/llvm/test/CodeGen/SPIRV/spec_const_decoration.ll
@@ -1,8 +1,5 @@
 ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
 
-; TODO: This test currently fails with LLVM_ENABLE_EXPENSIVE_CHECKS enabled
-; XFAIL: expensive_checks
-
 ; CHECK: OpDecorate %[[#SpecConst:]] SpecId 0
 ; CHECK: %[[#SpecConst]] = OpSpecConstant %[[#]] 70
 ; CHECK: %[[#]] = OpPhi %[[#]] %[[#]] %[[#]] %[[#SpecConst]] %[[#]]

>From b112f9f18a0e941c96a0039e38437ff4cc515e10 Mon Sep 17 00:00:00 2001
From: Arseniy Obolenskiy <arseniy.obolenskiy at amd.com>
Date: Wed, 1 Apr 2026 12:47:51 +0200
Subject: [PATCH 2/2] add -verify-machineinstrs

---
 llvm/test/CodeGen/SPIRV/spec_const_decoration.ll | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/test/CodeGen/SPIRV/spec_const_decoration.ll b/llvm/test/CodeGen/SPIRV/spec_const_decoration.ll
index a5d8b9962ac92..0129fcc83ba82 100644
--- a/llvm/test/CodeGen/SPIRV/spec_const_decoration.ll
+++ b/llvm/test/CodeGen/SPIRV/spec_const_decoration.ll
@@ -1,4 +1,4 @@
-; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
 
 ; CHECK: OpDecorate %[[#SpecConst:]] SpecId 0
 ; CHECK: %[[#SpecConst]] = OpSpecConstant %[[#]] 70



More information about the llvm-commits mailing list