[llvm] [DebugInfo][X86] Use merged DebugLoc in replaceBranchWithTailCall (PR #189509)

[Jeremy Morse via llvm-commits]

jmorse wrote:

No strong opinions from me, I broadly agree with @SLTozer / @OCHyams. Is the distinguishing feature here purely because the instruction is about control flow, rather than computing a value, and would we be better off with some rules for updating control-flow instructions?

I feel the true objective is "don't be misleading", but that's hard to describe concisely in words, thus the updating-source-locations document is written to encourage behaviour that doesn't mislead, at the cost of a few scenarios where there are more optimal choices (such as this).

https://github.com/llvm/llvm-project/pull/189509