[llvm] [Support] Optimize parallel `TaskGroup` (PR #189196)
Alexandre Ganea via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 29 18:01:04 PDT 2026
================
@@ -141,34 +141,39 @@ class ThreadPoolExecutor {
[&] { TheJobserver->release(std::move(Slot)); });
while (true) {
- std::function<void()> Task;
- {
- std::unique_lock<std::mutex> Lock(Mutex);
- Cond.wait(Lock, [&] { return Stop || !WorkStack.empty(); });
- if (Stop && WorkStack.empty())
- return;
- if (WorkStack.empty())
- break;
- Task = std::move(WorkStack.back());
- WorkStack.pop_back();
- }
- Task();
+ std::unique_lock<std::mutex> Lock(Mutex);
+ Cond.wait(Lock, [&] { return Stop || !WorkStack.empty(); });
+ if (Stop && WorkStack.empty())
+ return;
+ if (WorkStack.empty())
+ break;
+ auto Item = std::move(WorkStack.back());
+ WorkStack.pop_back();
+ Lock.unlock();
+ Item.F();
+ Item.L.get().dec();
}
} else {
std::unique_lock<std::mutex> Lock(Mutex);
Cond.wait(Lock, [&] { return Stop || !WorkStack.empty(); });
if (Stop)
break;
- auto Task = std::move(WorkStack.back());
+ auto Item = std::move(WorkStack.back());
WorkStack.pop_back();
Lock.unlock();
- Task();
+ Item.F();
+ Item.L.get().dec();
}
}
}
+ struct WorkItem {
----------------
aganea wrote:
Maybe move this higher, before it is used?
https://github.com/llvm/llvm-project/pull/189196
More information about the llvm-commits
mailing list