[llvm] [MC] Remove unused NoExecStack parameter from MCStreamer::initSections. NFC (PR #188184)
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 24 00:12:54 PDT 2026
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/188184
Unused after commit 34bc5d580b73c0ca79653bb03e5c50419be2c634
>From 4c4546f9d3434313bff855f8daa4552e29601aad Mon Sep 17 00:00:00 2001
From: Fangrui Song <i at maskray.me>
Date: Tue, 24 Mar 2026 00:10:02 -0700
Subject: [PATCH] [MC] Remove unused NoExecStack parameter from
MCStreamer::initSections. NFC
Unused after commit 34bc5d580b73c0ca79653bb03e5c50419be2c634
---
bolt/lib/Core/BinaryContext.cpp | 2 +-
bolt/lib/Core/BinaryEmitter.cpp | 2 +-
bolt/lib/Passes/AsmDump.cpp | 2 +-
llvm/include/llvm/MC/MCELFStreamer.h | 2 +-
llvm/include/llvm/MC/MCStreamer.h | 2 +-
llvm/include/llvm/MC/MCWinCOFFStreamer.h | 2 +-
llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 2 +-
llvm/lib/MC/MCELFStreamer.cpp | 2 +-
llvm/lib/MC/MCParser/AsmParser.cpp | 4 ++--
llvm/lib/MC/MCParser/MasmParser.cpp | 4 ++--
llvm/lib/MC/MCStreamer.cpp | 2 +-
llvm/lib/MC/MCWinCOFFStreamer.cpp | 3 +--
llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 2 +-
llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp | 2 +-
llvm/tools/llvm-ml/Disassembler.cpp | 2 +-
.../DebugInfo/DWARF/DWARFExpressionCopyBytesTest.cpp | 2 +-
llvm/unittests/MC/DwarfLineTableHeaders.cpp | 2 +-
17 files changed, 19 insertions(+), 20 deletions(-)
diff --git a/bolt/lib/Core/BinaryContext.cpp b/bolt/lib/Core/BinaryContext.cpp
index 5b3baf1669624..d1ef796b44a61 100644
--- a/bolt/lib/Core/BinaryContext.cpp
+++ b/bolt/lib/Core/BinaryContext.cpp
@@ -2628,7 +2628,7 @@ BinaryContext::calculateEmittedSize(BinaryFunction &BF, bool FixBranches) {
*TheTriple, *LocalCtx, std::unique_ptr<MCAsmBackend>(MAB), std::move(OW),
std::unique_ptr<MCCodeEmitter>(MCEInstance.MCE.release()), *STI));
- Streamer->initSections(false, *STI);
+ Streamer->initSections(*STI);
MCSection *Section = MCEInstance.LocalMOFI->getTextSection();
Section->setHasInstructions(true);
diff --git a/bolt/lib/Core/BinaryEmitter.cpp b/bolt/lib/Core/BinaryEmitter.cpp
index 025516af82023..49604542cc7da 100644
--- a/bolt/lib/Core/BinaryEmitter.cpp
+++ b/bolt/lib/Core/BinaryEmitter.cpp
@@ -194,7 +194,7 @@ class BinaryEmitter {
} // anonymous namespace
void BinaryEmitter::emitAll(StringRef OrgSecPrefix) {
- Streamer.initSections(false, *BC.STI);
+ Streamer.initSections(*BC.STI);
Streamer.setUseAssemblerInfoForParsing(false);
if (opts::UpdateDebugSections && BC.isELF()) {
diff --git a/bolt/lib/Passes/AsmDump.cpp b/bolt/lib/Passes/AsmDump.cpp
index 0bc5a06f53ac2..8506d7054c4e8 100644
--- a/bolt/lib/Passes/AsmDump.cpp
+++ b/bolt/lib/Passes/AsmDump.cpp
@@ -142,7 +142,7 @@ void dumpFunction(const BinaryFunction &BF) {
std::unique_ptr<MCStreamer> AsmStreamer(createAsmStreamer(
*LocalCtx, std::move(FOut), std::move(InstructionPrinter),
std::move(MCEInstance.MCE), std::move(MAB)));
- AsmStreamer->initSections(true, *BC.STI);
+ AsmStreamer->initSections(*BC.STI);
std::unique_ptr<TargetMachine> TM(BC.TheTarget->createTargetMachine(
*BC.TheTriple, "", "", TargetOptions(), std::nullopt));
std::unique_ptr<AsmPrinter> MAP(
diff --git a/llvm/include/llvm/MC/MCELFStreamer.h b/llvm/include/llvm/MC/MCELFStreamer.h
index 144f6bc3bd91c..5c3246e42c3f3 100644
--- a/llvm/include/llvm/MC/MCELFStreamer.h
+++ b/llvm/include/llvm/MC/MCELFStreamer.h
@@ -47,7 +47,7 @@ class MCELFStreamer : public MCObjectStreamer {
/// \name MCStreamer Interface
/// @{
- void initSections(bool NoExecStack, const MCSubtargetInfo &STI) override;
+ void initSections(const MCSubtargetInfo &STI) override;
void changeSection(MCSection *Section, uint32_t Subsection = 0) override;
void emitLabel(MCSymbol *Symbol, SMLoc Loc = SMLoc()) override;
void emitLabelAtPos(MCSymbol *Symbol, SMLoc Loc, MCFragment &F,
diff --git a/llvm/include/llvm/MC/MCStreamer.h b/llvm/include/llvm/MC/MCStreamer.h
index 148d69ae5098f..254220f0e4f91 100644
--- a/llvm/include/llvm/MC/MCStreamer.h
+++ b/llvm/include/llvm/MC/MCStreamer.h
@@ -468,7 +468,7 @@ class LLVM_ABI MCStreamer {
void switchSectionNoPrint(MCSection *Section);
/// Create the default sections and set the initial one.
- virtual void initSections(bool NoExecStack, const MCSubtargetInfo &STI);
+ virtual void initSections(const MCSubtargetInfo &STI);
MCSymbol *endSection(MCSection *Section);
diff --git a/llvm/include/llvm/MC/MCWinCOFFStreamer.h b/llvm/include/llvm/MC/MCWinCOFFStreamer.h
index 45849b99de36a..db1cdbc6fb816 100644
--- a/llvm/include/llvm/MC/MCWinCOFFStreamer.h
+++ b/llvm/include/llvm/MC/MCWinCOFFStreamer.h
@@ -42,7 +42,7 @@ class MCWinCOFFStreamer : public MCObjectStreamer {
/// \name MCStreamer interface
/// \{
- void initSections(bool NoExecStack, const MCSubtargetInfo &STI) override;
+ void initSections(const MCSubtargetInfo &STI) override;
void changeSection(MCSection *Section, uint32_t Subsection = 0) override;
void emitLabel(MCSymbol *Symbol, SMLoc Loc = SMLoc()) override;
bool emitSymbolAttribute(MCSymbol *Symbol, MCSymbolAttr Attribute) override;
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index db4fc5888f6d4..c3b8753c40a0d 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -556,7 +556,7 @@ bool AsmPrinter::doInitialization(Module &M) {
// information (such as the embedded command line) to be associated
// with all sections in the object file rather than a single section.
if (!Target.isOSBinFormatXCOFF())
- OutStreamer->initSections(false, *TM.getMCSubtargetInfo());
+ OutStreamer->initSections(*TM.getMCSubtargetInfo());
// Emit the version-min deployment target directive if needed.
//
diff --git a/llvm/lib/MC/MCELFStreamer.cpp b/llvm/lib/MC/MCELFStreamer.cpp
index 2adb8901d69df..7fc4a7f9a05ca 100644
--- a/llvm/lib/MC/MCELFStreamer.cpp
+++ b/llvm/lib/MC/MCELFStreamer.cpp
@@ -49,7 +49,7 @@ ELFObjectWriter &MCELFStreamer::getWriter() {
return static_cast<ELFObjectWriter &>(getAssembler().getWriter());
}
-void MCELFStreamer::initSections(bool, const MCSubtargetInfo &STI) {
+void MCELFStreamer::initSections(const MCSubtargetInfo &STI) {
MCContext &Ctx = getContext();
switchSection(Ctx.getObjectFileInfo()->getTextSection());
emitCodeAlignment(Align(Ctx.getObjectFileInfo()->getTextSectionAlignment()),
diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp
index e3c3f483a789a..938eac7b05fb6 100644
--- a/llvm/lib/MC/MCParser/AsmParser.cpp
+++ b/llvm/lib/MC/MCParser/AsmParser.cpp
@@ -942,7 +942,7 @@ bool AsmParser::Run(bool NoInitialTextSection, bool NoFinalize) {
// Create the initial section, if requested.
if (!NoInitialTextSection)
- Out.initSections(false, getTargetParser().getSTI());
+ Out.initSections(getTargetParser().getSTI());
// Prime the lexer.
Lex();
@@ -1056,7 +1056,7 @@ bool AsmParser::Run(bool NoInitialTextSection, bool NoFinalize) {
bool AsmParser::checkForValidSection() {
if (!ParsingMSInlineAsm && !getStreamer().getCurrentFragment()) {
- Out.initSections(false, getTargetParser().getSTI());
+ Out.initSections(getTargetParser().getSTI());
return Error(getTok().getLoc(),
"expected section directive before assembly directive");
}
diff --git a/llvm/lib/MC/MCParser/MasmParser.cpp b/llvm/lib/MC/MCParser/MasmParser.cpp
index 451c02c6794cc..cda16e37cc038 100644
--- a/llvm/lib/MC/MCParser/MasmParser.cpp
+++ b/llvm/lib/MC/MCParser/MasmParser.cpp
@@ -1203,7 +1203,7 @@ const AsmToken MasmParser::peekTok(bool ShouldSkipSpace) {
bool MasmParser::Run(bool NoInitialTextSection, bool NoFinalize) {
// Create the initial section, if requested.
if (!NoInitialTextSection)
- Out.initSections(false, getTargetParser().getSTI());
+ Out.initSections(getTargetParser().getSTI());
// Prime the lexer.
Lex();
@@ -1273,7 +1273,7 @@ bool MasmParser::Run(bool NoInitialTextSection, bool NoFinalize) {
bool MasmParser::checkForValidSection() {
if (!ParsingMSInlineAsm && !(getStreamer().getCurrentFragment() &&
getStreamer().getCurrentSectionOnly())) {
- Out.initSections(false, getTargetParser().getSTI());
+ Out.initSections(getTargetParser().getSTI());
return Error(getTok().getLoc(),
"expected section directive before assembly directive");
}
diff --git a/llvm/lib/MC/MCStreamer.cpp b/llvm/lib/MC/MCStreamer.cpp
index 35203b904fbe6..0ee6f490b4be5 100644
--- a/llvm/lib/MC/MCStreamer.cpp
+++ b/llvm/lib/MC/MCStreamer.cpp
@@ -386,7 +386,7 @@ void MCStreamer::emitEHSymAttributes(const MCSymbol *Symbol,
MCSymbol *EHSymbol) {
}
-void MCStreamer::initSections(bool NoExecStack, const MCSubtargetInfo &STI) {
+void MCStreamer::initSections(const MCSubtargetInfo &STI) {
switchSectionNoPrint(getContext().getObjectFileInfo()->getTextSection());
}
diff --git a/llvm/lib/MC/MCWinCOFFStreamer.cpp b/llvm/lib/MC/MCWinCOFFStreamer.cpp
index 2e632deaf3276..bd6a86e099d28 100644
--- a/llvm/lib/MC/MCWinCOFFStreamer.cpp
+++ b/llvm/lib/MC/MCWinCOFFStreamer.cpp
@@ -134,8 +134,7 @@ WinCOFFObjectWriter &MCWinCOFFStreamer::getWriter() {
return static_cast<WinCOFFObjectWriter &>(getAssembler().getWriter());
}
-void MCWinCOFFStreamer::initSections(bool NoExecStack,
- const MCSubtargetInfo &STI) {
+void MCWinCOFFStreamer::initSections(const MCSubtargetInfo &STI) {
// FIXME: this is identical to the ELF one.
// This emulates the same behavior of GNU as. This makes it easier
// to compare the output as the major sections are in the same order.
diff --git a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
index a8fad41e4bdd3..5dfec3f18814c 100644
--- a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
+++ b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
@@ -12322,7 +12322,7 @@ bool ARMAsmParser::parseDirectiveEven(SMLoc L) {
return true;
if (!Section) {
- getStreamer().initSections(false, getSTI());
+ getStreamer().initSections(getSTI());
Section = getStreamer().getCurrentSectionOnly();
}
diff --git a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
index d1dda4debe229..9d8b74284a3de 100644
--- a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
+++ b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
@@ -4877,7 +4877,7 @@ bool X86AsmParser::parseDirectiveEven(SMLoc L) {
const MCSection *Section = getStreamer().getCurrentSectionOnly();
if (!Section) {
- getStreamer().initSections(false, getSTI());
+ getStreamer().initSections(getSTI());
Section = getStreamer().getCurrentSectionOnly();
}
if (getContext().getAsmInfo()->useCodeAlign(*Section))
diff --git a/llvm/tools/llvm-ml/Disassembler.cpp b/llvm/tools/llvm-ml/Disassembler.cpp
index 0b34a1e14d5b7..330f54e9242cf 100644
--- a/llvm/tools/llvm-ml/Disassembler.cpp
+++ b/llvm/tools/llvm-ml/Disassembler.cpp
@@ -153,7 +153,7 @@ int Disassembler::disassemble(const Target &T, const std::string &TripleName,
}
// Set up initial section manually here
- Streamer.initSections(false, STI);
+ Streamer.initSections(STI);
bool ErrorOccurred = false;
diff --git a/llvm/unittests/DebugInfo/DWARF/DWARFExpressionCopyBytesTest.cpp b/llvm/unittests/DebugInfo/DWARF/DWARFExpressionCopyBytesTest.cpp
index 037af87fdab09..4992b2d7abf36 100644
--- a/llvm/unittests/DebugInfo/DWARF/DWARFExpressionCopyBytesTest.cpp
+++ b/llvm/unittests/DebugInfo/DWARF/DWARFExpressionCopyBytesTest.cpp
@@ -132,7 +132,7 @@ SmallString<0> DWARFExpressionCopyBytesTest::emitObjFile(StringRef ExprBytes) {
SmallString<0> Storage;
raw_svector_ostream VecOS(Storage);
StreamerContext C = createStreamer(VecOS);
- C.Streamer->initSections(false, *STI);
+ C.Streamer->initSections(*STI);
MCSection *Section = C.MOFI->getTextSection();
Section->setHasInstructions(true);
C.Streamer->switchSection(Section);
diff --git a/llvm/unittests/MC/DwarfLineTableHeaders.cpp b/llvm/unittests/MC/DwarfLineTableHeaders.cpp
index f685f28619135..3aef4862e31f6 100644
--- a/llvm/unittests/MC/DwarfLineTableHeaders.cpp
+++ b/llvm/unittests/MC/DwarfLineTableHeaders.cpp
@@ -93,7 +93,7 @@ class DwarfLineTableHeaders : public ::testing::Test {
MCStreamer *TheStreamer = C.Streamer.get();
MCAssembler &Assembler =
static_cast<MCObjectStreamer *>(TheStreamer)->getAssembler();
- TheStreamer->initSections(false, *STI);
+ TheStreamer->initSections(*STI);
// Create a mock function
MCSection *Section = C.MOFI->getTextSection();
More information about the llvm-commits
mailing list