[llvm] [RISCV][NFC] Remove duplicate setTargetDAGCombine registrations (PR #186928)
Jim Lin via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 16 17:56:52 PDT 2026
https://github.com/tclin914 created https://github.com/llvm/llvm-project/pull/186928
ISD::SRA and ISD::MUL are already registered unconditionally in the constructor, so remove the redundant registrations from the hasVInstructions() block. Fold the standalone SRA call into the existing brace-initializer list.
>From 9d098cc04585ecebb634c8e5fa207625c3598018 Mon Sep 17 00:00:00 2001
From: Jim Lin <jim at andestech.com>
Date: Tue, 17 Mar 2026 08:38:56 +0800
Subject: [PATCH] [RISCV][NFC] Remove duplicate setTargetDAGCombine
registrations
ISD::SRA and ISD::MUL are already registered unconditionally in the
constructor, so remove the redundant registrations from the
hasVInstructions() block. Fold the standalone SRA call into the
existing brace-initializer list.
Co-Authored-By: Claude Opus 4.6 <noreply at anthropic.com>
---
llvm/lib/Target/RISCV/RISCVISelLowering.cpp | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index 7e0c6a6aedfcc..d76a251248f2e 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -1885,8 +1885,8 @@ RISCVTargetLowering::RISCVTargetLowering(const TargetMachine &TM,
setTargetDAGCombine({ISD::INTRINSIC_VOID, ISD::INTRINSIC_W_CHAIN,
ISD::INTRINSIC_WO_CHAIN, ISD::ADD, ISD::SUB, ISD::MUL,
- ISD::AND, ISD::OR, ISD::XOR, ISD::SETCC, ISD::SELECT});
- setTargetDAGCombine(ISD::SRA);
+ ISD::AND, ISD::OR, ISD::XOR, ISD::SETCC, ISD::SELECT,
+ ISD::SRA});
setTargetDAGCombine(ISD::SIGN_EXTEND_INREG);
if (Subtarget.hasStdExtFOrZfinx())
@@ -1908,12 +1908,12 @@ RISCVTargetLowering::RISCVTargetLowering(const TargetMachine &TM,
if (Subtarget.hasVInstructions())
setTargetDAGCombine(
{ISD::FCOPYSIGN, ISD::MGATHER, ISD::MSCATTER,
- ISD::VP_GATHER, ISD::VP_SCATTER, ISD::SRA,
- ISD::SRL, ISD::SHL, ISD::STORE,
- ISD::SPLAT_VECTOR, ISD::BUILD_VECTOR, ISD::CONCAT_VECTORS,
+ ISD::VP_GATHER, ISD::VP_SCATTER, ISD::SRL,
+ ISD::SHL, ISD::STORE, ISD::SPLAT_VECTOR,
+ ISD::BUILD_VECTOR, ISD::CONCAT_VECTORS,
ISD::VP_STORE, ISD::VP_TRUNCATE, ISD::EXPERIMENTAL_VP_REVERSE,
- ISD::MUL, ISD::SDIV, ISD::UDIV,
- ISD::SREM, ISD::UREM, ISD::INSERT_VECTOR_ELT,
+ ISD::SDIV, ISD::UDIV, ISD::SREM,
+ ISD::UREM, ISD::INSERT_VECTOR_ELT,
ISD::ABS, ISD::CTPOP, ISD::VECTOR_SHUFFLE,
ISD::FMA, ISD::VSELECT, ISD::VECREDUCE_ADD});
More information about the llvm-commits
mailing list