[llvm] [NFC][DominanceFrontier] Remove unused return value (PR #178708)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 29 09:48:42 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-analysis
Author: Andrei Elovikov (eas)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/178708.diff
2 Files Affected:
- (modified) llvm/include/llvm/Analysis/DominanceFrontier.h (+1-1)
- (modified) llvm/include/llvm/Analysis/DominanceFrontierImpl.h (+2-7)
``````````diff
diff --git a/llvm/include/llvm/Analysis/DominanceFrontier.h b/llvm/include/llvm/Analysis/DominanceFrontier.h
index 787793501f98a..ec49b36d64cfd 100644
--- a/llvm/include/llvm/Analysis/DominanceFrontier.h
+++ b/llvm/include/llvm/Analysis/DominanceFrontier.h
@@ -116,7 +116,7 @@ class ForwardDominanceFrontierBase
calculate(DT, DT[this->Roots[0]]);
}
- const DomSetType &calculate(const DomTreeT &DT, const DomTreeNodeT *Node);
+ void calculate(const DomTreeT &DT, const DomTreeNodeT *Node);
};
class DominanceFrontier : public ForwardDominanceFrontierBase<BasicBlock> {
diff --git a/llvm/include/llvm/Analysis/DominanceFrontierImpl.h b/llvm/include/llvm/Analysis/DominanceFrontierImpl.h
index 1483588581f4e..c7fc463fd3af5 100644
--- a/llvm/include/llvm/Analysis/DominanceFrontierImpl.h
+++ b/llvm/include/llvm/Analysis/DominanceFrontierImpl.h
@@ -74,11 +74,9 @@ void DominanceFrontierBase<BlockT, IsPostDom>::dump() const {
#endif
template <class BlockT>
-const typename ForwardDominanceFrontierBase<BlockT>::DomSetType &
-ForwardDominanceFrontierBase<BlockT>::calculate(const DomTreeT &DT,
- const DomTreeNodeT *Node) {
+void ForwardDominanceFrontierBase<BlockT>::calculate(const DomTreeT &DT,
+ const DomTreeNodeT *Node) {
BlockT *BB = Node->getBlock();
- DomSetType *Result = nullptr;
std::vector<DFCalculateWorkObject<BlockT>> workList;
SmallPtrSet<BlockT *, 32> visited;
@@ -126,7 +124,6 @@ ForwardDominanceFrontierBase<BlockT>::calculate(const DomTreeT &DT,
// from the workList.
if (!visitChild) {
if (!parentBB) {
- Result = &S;
break;
}
@@ -140,8 +137,6 @@ ForwardDominanceFrontierBase<BlockT>::calculate(const DomTreeT &DT,
}
} while (!workList.empty());
-
- return *Result;
}
} // end namespace llvm
``````````
</details>
https://github.com/llvm/llvm-project/pull/178708
More information about the llvm-commits
mailing list