[llvm] [NFCI][Coroutines] update tests to autogenerated formatting (PR #178358)

Christian Ulmann via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 29 01:45:18 PST 2026


Dinistro wrote:

Disclaimer: I'm mainly an MLIR person and was only doing minor things in the coroutine passes. Because of this, my views might not fully align with LLVM's guidelines.

The main problem with the coroutine passes is the fact that they produce a lot of IR. I think the current aim is to have unit tests for specific cases of the massive passes, which attempt to be focused to only check things on that side (I'm not saying that this is true for all the tests).

Regarding the term "regression test": Is this considered to be the same as a unit test in all cases? If so, then writing focused tests would be a non-goal, which seems to be in conflict of what many parts are trying to achieve. Specifically, tests in MLIR usually try to check the smallest possible thing that is relevant for the pass at hand, while deliberately ignoring things that are not part of the pass, e.g., types, default values, etc.

https://github.com/llvm/llvm-project/pull/178358


More information about the llvm-commits mailing list