[llvm] [Offload][AMDGPU] Fix olQueryQueue uninitialized output parameter (PR #178464)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 28 08:48:59 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-offload
Author: puneeth_aditya_5656 (mugiwaraluffy56)
<details>
<summary>Changes</summary>
## Summary
- Fix uninitialized output parameter in `olQueryQueue_impl` when `Queue->AsyncInfo->Queue` is null
- Set `IsQueueWorkCompleted` to `true` when no underlying queue exists (no pending work)
- Resolves test failure on AMDGPU for `olQueryQueueTest.SuccessEmptyAsyncQueueCheckResult`
Fixes #<!-- -->178462.
## Test plan
- [x] Fixed `OffloadAPI/queue.unittests/olQueryQueueTest/SuccessEmptyAsyncQueueCheckResult/AMDGPU_AMD_Radeon_RX_7700_XT_0` test
- [ ] CI tests pass
---
Full diff: https://github.com/llvm/llvm-project/pull/178464.diff
1 Files Affected:
- (modified) offload/liboffload/src/OffloadImpl.cpp (+3)
``````````diff
diff --git a/offload/liboffload/src/OffloadImpl.cpp b/offload/liboffload/src/OffloadImpl.cpp
index 6e429a574bfe2..3fb587309022e 100644
--- a/offload/liboffload/src/OffloadImpl.cpp
+++ b/offload/liboffload/src/OffloadImpl.cpp
@@ -1254,6 +1254,9 @@ Error olQueryQueue_impl(ol_queue_handle_t Queue, bool *IsQueueWorkCompleted) {
if (auto Err = Queue->Device->Device->queryAsync(Queue->AsyncInfo, false,
IsQueueWorkCompleted))
return Err;
+ } else if (IsQueueWorkCompleted) {
+ // No underlying queue means there's no work to complete
+ *IsQueueWorkCompleted = true;
}
return Error::success();
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/178464
More information about the llvm-commits
mailing list