[llvm] [perf] Replace copy-assign by move-assign in llvm/lib/DWARFCFIChecker… (PR #178174)

[AmirHossein PashaeeHir via llvm-commits]

https://github.com/amsen20 commented:

I don't see a problem with the change in `DWARFCFIChecker`. The `NewRow` is a local value, and it is OK to move it.

About the other change, I think it would be better if you could add a reviewer who previously worked on that part of the code.
My only comment is that the `BinaryStreamRef Contents` is an argument, and moving it should be documented in the `initialize` method. Hence, the user of the method knows that the argument is not usable after the method.
Maybe this is not the case for the current implementation, but any change to the move semantics of `BinaryStreamRef` would likely introduce a bug here.


https://github.com/llvm/llvm-project/pull/178174