[llvm] [LV] Support argmin/argmax with strict predicates. (PR #170223)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 24 05:47:11 PST 2026
================
@@ -1390,7 +1392,136 @@ bool VPlanTransforms::handleFindLastReductions(VPlan &Plan) {
return true;
}
-bool VPlanTransforms::handleMultiUseReductions(VPlan &Plan) {
+/// For argmin/argmax reductions with strict predicates, convert the existing
+/// FindLastIV reduction to a new UMin reduction of a wide canonical IV. If the
+/// original IV was not canonical, a new canonical wide IV is added, and the
+/// final result is scaled back to the original IV.
+static bool handleFirstArgMinOrMax(VPlan &Plan,
+ VPReductionPHIRecipe *MinOrMaxPhiR,
+ VPReductionPHIRecipe *FindLastIVPhiR,
+ VPWidenIntOrFpInductionRecipe *WideIV,
+ VPInstruction *MinOrMaxResult) {
+ Type *Ty = Plan.getVectorLoopRegion()->getCanonicalIVType();
+ // TODO: Support non (i.e., narrower than) canonical IV types.
+ if (Ty != VPTypeAnalysis(Plan).inferScalarType(WideIV))
+ return false;
+
+ // If the original wide IV is not canonical, create a new one. The wide IV is
+ // guaranteed to not wrap for all lanes that are active in the vector loop.
+ auto *FindIVSelectR = cast<VPSingleDefRecipe>(
+ FindLastIVPhiR->getBackedgeValue()->getDefiningRecipe());
+ if (!WideIV->isCanonical()) {
+ VPIRValue *Zero = Plan.getConstantInt(Ty, 0);
+ VPIRValue *One = Plan.getConstantInt(Ty, 1);
+ auto *WidenCanIV = new VPWidenIntOrFpInductionRecipe(
+ nullptr, Zero, One, WideIV->getVFValue(),
+ WideIV->getInductionDescriptor(),
+ VPIRFlags::WrapFlagsTy(/*HasNUW=*/true, /*HasNSW=*/false),
+ WideIV->getDebugLoc());
+ WidenCanIV->insertBefore(WideIV);
+
+ // Update the select to use the wide canonical IV.
+ assert(
+ match(FindIVSelectR, m_Select(m_VPValue(), m_VPValue(), m_VPValue())) &&
+ "backedge value must be a select");
+ WideIV->replaceUsesWithIf(WidenCanIV,
+ [FindIVSelectR](const VPUser &U, unsigned) {
+ return FindIVSelectR == &U;
+ });
----------------
ayalz wrote:
Is there a simpler way to have FindIVSelectR use WidenCanIV instead of WideIV?
https://github.com/llvm/llvm-project/pull/170223
More information about the llvm-commits
mailing list