[llvm] [StaticDataLayout] Temporarily undo diagnostic warning when the data access profile payload is not available (PR #177412)
Mingming Liu via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 22 10:09:02 PST 2026
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/177412
>From cb1281aaa074a099e4edc3ed6974846a5870fe01 Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Sun, 21 Dec 2025 21:00:53 -0800
Subject: [PATCH 1/3] [NFC]Tidy whitespace in llvm-profdata memprof YAML output
---
llvm/lib/ProfileData/MemProfSummary.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/llvm/lib/ProfileData/MemProfSummary.cpp b/llvm/lib/ProfileData/MemProfSummary.cpp
index 1690745debf54..cec9ef5a57b1a 100644
--- a/llvm/lib/ProfileData/MemProfSummary.cpp
+++ b/llvm/lib/ProfileData/MemProfSummary.cpp
@@ -26,10 +26,10 @@ void MemProfSummary::printSummaryYaml(raw_ostream &OS) const {
OS << "# Maximum warm context total size: " << MaxWarmTotalSize << "\n";
OS << "# Maximum hot context total size: " << MaxHotTotalSize << "\n";
if (HasDataAccessProfile) {
- OS << "# Num hot symbols and string literals: "
+ OS << "# Num hot symbols and string literals: "
<< NumHotSymbolsAndStringLiterals << "\n";
- OS << "# Num known cold symbols: " << NumKnownColdSymbols << "\n";
- OS << "# Num known cold string literals: " << NumKnownColdStringLiterals
+ OS << "# Num known cold symbols: " << NumKnownColdSymbols << "\n";
+ OS << "# Num known cold string literals: " << NumKnownColdStringLiterals
<< "\n";
}
}
>From b43764ea46179b06b759b25fc2cece939f06e42b Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Thu, 22 Jan 2026 09:49:03 -0800
Subject: [PATCH 2/3] [StaticDataLayout]Undo the diagnostic warning when data
access profile payload is not available
---
llvm/lib/Transforms/Instrumentation/MemProfUse.cpp | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/llvm/lib/Transforms/Instrumentation/MemProfUse.cpp b/llvm/lib/Transforms/Instrumentation/MemProfUse.cpp
index 1a55021c5d3f7..748c4cb711027 100644
--- a/llvm/lib/Transforms/Instrumentation/MemProfUse.cpp
+++ b/llvm/lib/Transforms/Instrumentation/MemProfUse.cpp
@@ -910,11 +910,8 @@ bool MemProfUsePass::annotateGlobalVariables(
if (!DataAccessProf) {
M.addModuleFlag(Module::Warning, "EnableDataAccessProf", 0U);
- M.getContext().diagnose(DiagnosticInfoPGOProfile(
- MemoryProfileFileName.data(),
- StringRef("Data access profiles not found in memprof. Ignore "
- "-memprof-annotate-static-data-prefix."),
- DS_Warning));
+ // FIXME: Add a diagnostic message without failing the compilation when
+ // data access profile payload is not available.
return false;
}
M.addModuleFlag(Module::Warning, "EnableDataAccessProf", 1U);
>From dc41bfff633762f2add3a14c5270d0fe82f3bfaf Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Thu, 22 Jan 2026 10:08:43 -0800
Subject: [PATCH 3/3] undo whitespace changes
---
llvm/lib/ProfileData/MemProfSummary.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/llvm/lib/ProfileData/MemProfSummary.cpp b/llvm/lib/ProfileData/MemProfSummary.cpp
index cec9ef5a57b1a..1690745debf54 100644
--- a/llvm/lib/ProfileData/MemProfSummary.cpp
+++ b/llvm/lib/ProfileData/MemProfSummary.cpp
@@ -26,10 +26,10 @@ void MemProfSummary::printSummaryYaml(raw_ostream &OS) const {
OS << "# Maximum warm context total size: " << MaxWarmTotalSize << "\n";
OS << "# Maximum hot context total size: " << MaxHotTotalSize << "\n";
if (HasDataAccessProfile) {
- OS << "# Num hot symbols and string literals: "
+ OS << "# Num hot symbols and string literals: "
<< NumHotSymbolsAndStringLiterals << "\n";
- OS << "# Num known cold symbols: " << NumKnownColdSymbols << "\n";
- OS << "# Num known cold string literals: " << NumKnownColdStringLiterals
+ OS << "# Num known cold symbols: " << NumKnownColdSymbols << "\n";
+ OS << "# Num known cold string literals: " << NumKnownColdStringLiterals
<< "\n";
}
}
More information about the llvm-commits
mailing list