[llvm] [BOLT] Update obsolete test cases of llvm-bolt-binary-analysis (PR #176997)

Harald van Dijk via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 21 08:39:39 PST 2026


================
@@ -168,23 +168,6 @@ f_nonx30_ret_ok:
         ret     x16
         .size f_nonx30_ret_ok, .-f_nonx30_ret_ok
 
-        .globl  f_detect_clobbered_x30_passed_to_other
-        .type   f_detect_clobbered_x30_passed_to_other, at function
-f_detect_clobbered_x30_passed_to_other:
-        str x30, [sp]
-        ldr x30, [sp]
-// FIXME: Ideally, the pac-ret scanner would report on the following instruction, which
-// performs a tail call, that x30 might be attacker-controlled.
-// CHECK-NOT: function f_detect_clobbered_x30_passed_to_other
----------------
hvdijk wrote:

Oh! Good spot, but I think that we do want this to work with `--scanners=pacret` as well, I think it still counts as a FIXME, because `--scanners=pauth` is not usable (and not meant to be usable) with code compiled with `-mbranch-protection=standard` which is what major distros are using, right?

https://github.com/llvm/llvm-project/pull/176997


More information about the llvm-commits mailing list