[llvm] [NFCI][LLVM] Remove `raw_string_ostream::flush` calls (PR #164086)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 13 08:44:25 PST 2026


jurahul wrote:

> > to raw_string_ostream, which atleast helped identify all the places that called flush() directly, but as I mentioned, the raw_string_ostream unit test still plays around with buffering, so I could not commit that change.
> 
> We can always drop the unittest if we decide that we do not need the functionality. I like @aengelke's suggestion on how to structure the API better than just deleting flush though.

Right, that was my thinking when I said we have separate buffered/unbuffered base classes and the buffering functions are available only for the buffered classes, so that its impossible to do any buffer control on any ostream derived from the unbuffered base class.

https://github.com/llvm/llvm-project/pull/164086


More information about the llvm-commits mailing list