[llvm] [NFC] Suppress cppcheck false-positives in llvm/include/llvm/Support/MathExtras.h (PR #175417)
Konrad Kleine via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 12 03:41:34 PST 2026
kwk wrote:
> It is up to the LLVM devs to decide if such annotations are desired in the code. The problem is that these annotations will rot if do not generate `unmatchedSuppression` messages which tells you that you have to remove them.
This is the same with essentially most comments in code. The worst thing that can happen is that a similar error is introduce when the line below the comment is changed and then hidden by comment that is still kept.
You can always look at the state of the file when the comment was introduced so it should be doable to analyse what the comment was initially meant for.
The best thing that can happen is that the number of false-positive reports is reduced and actual errors show up more prominently.
https://github.com/llvm/llvm-project/pull/175417
More information about the llvm-commits
mailing list