[compiler-rt] 9553f11 - [lit] Drop shell feature from all upstream projects (#173341)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 31 11:06:40 PST 2025
Author: Aiden Grossman
Date: 2025-12-31T11:06:36-08:00
New Revision: 9553f119b051c5d7e6cd05729a057e6799cbd1ce
URL: https://github.com/llvm/llvm-project/commit/9553f119b051c5d7e6cd05729a057e6799cbd1ce
DIFF: https://github.com/llvm/llvm-project/commit/9553f119b051c5d7e6cd05729a057e6799cbd1ce.diff
LOG: [lit] Drop shell feature from all upstream projects (#173341)
Now that no tests actually use the shell feature to conditionally run,
drop the feature altogether to prevent backslide.
Added:
Modified:
compiler-rt/test/lit.common.cfg.py
llvm/utils/lit/lit/llvm/config.py
Removed:
################################################################################
diff --git a/compiler-rt/test/lit.common.cfg.py b/compiler-rt/test/lit.common.cfg.py
index 19daa6bbec229..fa74408383638 100644
--- a/compiler-rt/test/lit.common.cfg.py
+++ b/compiler-rt/test/lit.common.cfg.py
@@ -126,8 +126,6 @@ def push_dynamic_library_lookup_path(config, new_path):
# Setup test format.
config.test_format = lit.formats.ShTest(execute_external)
-if execute_external:
- config.available_features.add("shell")
target_is_msvc = bool(re.match(r".*-windows-msvc$", config.target_triple))
target_is_windows = bool(re.match(r".*-windows.*$", config.target_triple))
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 28a7ab25a0c3b..8b794c6978890 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -79,9 +79,6 @@ def __init__(self, lit_config, config):
if not self.use_lit_shell and lit_config.update_tests:
print("note: --update-tests is not supported when using external shell")
- if not self.use_lit_shell:
- features.add("shell")
-
self.with_system_environment(
[
"ASAN_SYMBOLIZER_PATH",
More information about the llvm-commits
mailing list