[llvm] [LegalizeDAG] Remove unnecessary EVT->MVT->EVT conversion. NFC (PR #173707)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 26 21:52:24 PST 2025


https://github.com/topperc created https://github.com/llvm/llvm-project/pull/173707

There doesn't appear to be any reason to use MVT here. All of the uses expect an EVT.

>From 84e19982c4ba93725b9c31c3e64b3d1007d11594 Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper at sifive.com>
Date: Fri, 26 Dec 2025 21:49:58 -0800
Subject: [PATCH] [LegalizeDAG] Remove unnecessary EVT->MVT->EVT conversion.
 NFC

There doesn't appear to be any reason to use MVT here. All of the
uses expect an EVT.
---
 llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
index cb42d420ab3ca..6476b828448c5 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
@@ -4033,7 +4033,7 @@ bool SelectionDAGLegalize::ExpandNode(SDNode *Node) {
   case ISD::SMUL_LOHI: {
     SDValue LHS = Node->getOperand(0);
     SDValue RHS = Node->getOperand(1);
-    MVT VT = LHS.getSimpleValueType();
+    EVT VT = LHS.getValueType();
     unsigned MULHOpcode =
         Node->getOpcode() == ISD::UMUL_LOHI ? ISD::MULHU : ISD::MULHS;
 
@@ -4044,7 +4044,7 @@ bool SelectionDAGLegalize::ExpandNode(SDNode *Node) {
     }
 
     SmallVector<SDValue, 4> Halves;
-    EVT HalfType = EVT(VT).getHalfSizedIntegerVT(*DAG.getContext());
+    EVT HalfType = VT.getHalfSizedIntegerVT(*DAG.getContext());
     assert(TLI.isTypeLegal(HalfType));
     if (TLI.expandMUL_LOHI(Node->getOpcode(), VT, dl, LHS, RHS, Halves,
                            HalfType, DAG,



More information about the llvm-commits mailing list