[compiler-rt] [llvm] [lit] Drop shell feature from all upstream projects (PR #173341)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 22 23:12:56 PST 2025


https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/173341

Now that no tests actually use the shell feature to conditionally run, drop the feature altogether to prevent backslide.

>From eefc0b1a931654ce98745a5e81aa3657258e8b6e Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Tue, 23 Dec 2025 07:09:39 +0000
Subject: [PATCH] [lit] Drop shell feature from all upstream projects

Now that no tests actually use the shell feature to conditionally run,
drop the feature altogether to prevent backslide.
---
 compiler-rt/test/lit.common.cfg.py | 2 --
 llvm/utils/lit/lit/llvm/config.py  | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/compiler-rt/test/lit.common.cfg.py b/compiler-rt/test/lit.common.cfg.py
index 19daa6bbec229..fa74408383638 100644
--- a/compiler-rt/test/lit.common.cfg.py
+++ b/compiler-rt/test/lit.common.cfg.py
@@ -126,8 +126,6 @@ def push_dynamic_library_lookup_path(config, new_path):
 
 # Setup test format.
 config.test_format = lit.formats.ShTest(execute_external)
-if execute_external:
-    config.available_features.add("shell")
 
 target_is_msvc = bool(re.match(r".*-windows-msvc$", config.target_triple))
 target_is_windows = bool(re.match(r".*-windows.*$", config.target_triple))
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 28a7ab25a0c3b..8b794c6978890 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -79,9 +79,6 @@ def __init__(self, lit_config, config):
             if not self.use_lit_shell and lit_config.update_tests:
                 print("note: --update-tests is not supported when using external shell")
 
-        if not self.use_lit_shell:
-            features.add("shell")
-
         self.with_system_environment(
             [
                 "ASAN_SYMBOLIZER_PATH",



More information about the llvm-commits mailing list