[compiler-rt] [sanitizer_common] [Darwin] Fix typo in AtosSymbolizer error message (PR #173329)

Andrew Haberlandt via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 22 18:29:30 PST 2025


https://github.com/ndrewh created https://github.com/llvm/llvm-project/pull/173329

None

>From b10298bf8701b44ae313b213f5c838d5f5e5458d Mon Sep 17 00:00:00 2001
From: Andrew Haberlandt <ahaberlandt at apple.com>
Date: Mon, 22 Dec 2025 21:28:34 -0500
Subject: [PATCH] [sanitizer_common] [Darwin] Fix typo in AtosSymbolizer error
 message

---
 compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp | 4 ++--
 .../test/asan/TestCases/Darwin/atos-symbolized-recover.cpp    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp
index bb781ff9f72ed..d3259984b18a7 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp
@@ -215,8 +215,8 @@ bool AtosSymbolizer::SymbolizePC(uptr addr, SymbolizedStack *stack) {
 
     // Upon failure, ParseCommandOutput returns NULL.
     if (!buf) {
-      Report("WARNING: atos failed to symbolize buf address \"0x%zx\"\n", addr);
-      return NULL;
+      Report("WARNING: atos failed to symbolize address \"0x%zx\"\n", addr);
+      return false;
     }
     cur->info.line = (int)line;
 
diff --git a/compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp b/compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp
index 883202fa4e716..08b31af136fa0 100644
--- a/compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp
+++ b/compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp
@@ -14,6 +14,6 @@ void bar() {
 int main() {
   bar();
   return 0;
-  // CHECK: WARNING: atos failed to symbolize buf address{{.*}}
+  // CHECK: WARNING: atos failed to symbolize address{{.*}}
   // CHECK: {{.*}}atos-symbolized-recover.cpp:[[@LINE-3]]{{.*}}
 }
\ No newline at end of file



More information about the llvm-commits mailing list