[llvm] [llvm][utils] Make git-llvm-push not convert remote URLs (PR #173303)

[Aiden Grossman via llvm-commits]

================
@@ -375,11 +375,9 @@ class LLVMPRAutomator:
 
         git_env = self._get_git_env()
 
-        https_upstream_url = self._get_https_url_for_remote(self.config.upstream_remote)
+        upstream_url = self._get_url_for_remote(self.config.upstream_remote)
         refspec = f"refs/heads/{self.config.base_branch}:refs/remotes/{self.config.upstream_remote}/{self.config.base_branch}"
-        self.runner.run_command(
-            ["git", "fetch", https_upstream_url, refspec], env=git_env
-        )
+        self.runner.run_command(["git", "fetch", upstream_url, refspec], env=git_env)
----------------
boomanaiden154 wrote:

I talked with Paul offline about this and he mentioned that he entirely rewrote the script by hand from its original AI version.

I've updated the patch to just use remote names though. If we're already removing the canonicalization, it should be NFC to remove the conversion from name to URL.

https://github.com/llvm/llvm-project/pull/173303