[clang] [llvm] [HLSL][Matrix] Support row and column indexing modes for MatrixSubscriptExpr (PR #171564)

[Justin Bogner via llvm-commits]

================
@@ -238,19 +238,36 @@ class MatrixBuilder {
     else
       B.CreateAssumption(Cmp);
   }
-
-  /// Compute the index to access the element at (\p RowIdx, \p ColumnIdx) from
-  /// a matrix with \p NumRows embedded in a vector.
-  Value *CreateIndex(Value *RowIdx, Value *ColumnIdx, unsigned NumRows,
+  Value *createIndex(Value *RowIdx, Value *ColumnIdx, unsigned NumRows,
----------------
bogner wrote:

Please choose consistency with the existing code over clang-tidy's rules. While it's annoying that this class doesn't follow the LLVM conventions inconsistency is more painful to deal with.

https://github.com/llvm/llvm-project/pull/171564