[llvm] [CloneFunction] Optimize PHI incoming value removal using reverse iteration (NFC) (PR #171955)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 12 02:54:01 PST 2025


https://github.com/nikic approved this pull request.

I don't think you need to use addIncoming, the current code structure with setIncoming should work, as it only sets the current element. But overall, I agree that mixing modification and removal in removeIncomingValueIf() is a bit iffy. I'm fine with your change.

https://github.com/llvm/llvm-project/pull/171955


More information about the llvm-commits mailing list