[compiler-rt] [sanitizer_common] [Darwin] Add inline frame support for AtosSymbolizer (PR #170815)

Mariusz Borsa via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 11 12:03:33 PST 2025


================
@@ -102,12 +109,12 @@ class AtosSymbolizerProcess final : public SymbolizerProcess {
 
 #undef K_ATOS_ENV_VAR
 
-static bool ParseCommandOutput(const char *str, uptr addr, char **out_name,
-                               char **out_module, char **out_file, uptr *line,
-                               uptr *start_address) {
+static bool ParseCommandOutput(const char** str, uptr addr, char** out_name,
----------------
wrotki wrote:

So it was input parameter, now it looks like an output one. Feels a bit weird, why does the function named ParseCommandOutput modify its input?  And `const char **` - just gets confusing, this parameter is hardly constant (only pointer is)

https://github.com/llvm/llvm-project/pull/170815


More information about the llvm-commits mailing list