[llvm] [SYCL] Add platform enumeration and info query using liboffload (PR #166927)
Kseniya Tikhomirova via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 11 08:52:08 PST 2025
KseniyaTikhomirova wrote:
> > I'd like to define naming style for the upstreaming code base.
> > LLVM guide has no requirements about file names so I suggest:
> >
> > 1. all file names under `libsycl` folder (.h, .cpp, .md, etc) will be in snake_case (no exceptions)
> > 2. SYCL API type names - follow SYCL2020 spec naming - snake_case
> > 3. all detail (excluding STL-like types) types to use CamelCase.
>
> @KseniyaTikhomirova, please, create a libsycl/docs/CodingGuidelines.rst file and put your suggestion there. Let's separate this discussion from adding SYCL platform.
>
> > changes comparing to impl/llvm:
>
> What is impl/llvm? Do you mean intel/llvm repository?
thanks for suggestion, done https://github.com/llvm/llvm-project/pull/171867
@bader @tahonermann @AlexeySachkov @sergey-semenov @vinser52 it would be nice to get your opinion. I am not able to add you as reviewers to llvm-project PRs so inviting directly. Thanks.
https://github.com/llvm/llvm-project/pull/166927
More information about the llvm-commits
mailing list