[llvm] [mlir] [MLIR] convert OpAsmDialectInterface using ODS (PR #171488)

Jacques Pienaar via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 11 07:24:32 PST 2025


================
@@ -147,9 +157,17 @@ class TypeInterface<string name, list<Interface> baseInterfaces = []>
 			!if(!empty(cppNamespace),"", cppNamespace # "::") # name
     >;
 
+// AliasDeclaration represents an Alias Declaration in a Dialect Interface
----------------
jpienaar wrote:

I am semi surprised this is needed, didn't consider this as generally used. I found 8 files using OpAsmAliasResult and the rest uses the alias. It looks like it was done to avoid a cyclic dependency, but its a bit out of my cache. The alternative I could think of is a general "extraClassDecls" escape hatch where one could put arbitrary C++. Perhaps Mehdi has opinion here, this feels a bit bespoke to me, but not strong objection.

https://github.com/llvm/llvm-project/pull/171488


More information about the llvm-commits mailing list