[clang] [lld] [llvm] [RFC] Initial reference pass-plugin in LLVM (PR #171111)

[via llvm-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/171111 at github.com>


https://github.com/serge-sans-paille commented:

Another round of review, this time with a focus on data management. the Python C API requires a lot of hand-managed memory and you missed some of those, I flagged *some* of them, but not all.
I'd suggest, for the sake of maintainability, that you'd use dedicated type to encapsulate the C API to return, for instance, `std::unique_ptr<void*, PyDecRef>` or something along those lines.

https://github.com/llvm/llvm-project/pull/171111