[llvm] [llvm-symbolizer] Recognize AIX big archive (PR #150401)

[James Henderson via llvm-commits]

================
@@ -0,0 +1,33 @@
+// Test big archive recognition and error handling in llvm-symbolizer.
+
+// Generate object files.
+// RUN: yaml2obj -o %t-32.o %S/Inputs/big-archive-32.yaml
+// RUN: yaml2obj -o %t-64.o %S/Inputs/big-archive-64.yaml
+
+// Create archive with same-named members using different modes.
+// RUN: rm -f %t.a
+// RUN: cp %t-32.o %t.o
+// RUN: llvm-ar %if system-aix %{-X32%} crv %t.a %t.o
+// RUN: cp %t-64.o %t.o
+// RUN: llvm-ar %if system-aix %{-X64 rv%} %else %{qv%} %t.a %t.o
+
+// Verify archive contains two members with same name.
----------------
jh7370 wrote:

That wasn't my point. With this check, you are checking functionality of llvm-ar, not llvm-symbolizer, but this test is supposed to be a test for llvm-symbolizer, to verify that the behaviour change you have implemented works correctly. You don't need to check generic llvm-ar functionality in this test, because you can assume it works as it was previously implemented. Presumably there is coverage for this behaviour in the llvm-ar tests already?

https://github.com/llvm/llvm-project/pull/150401