[llvm] AMDGPU/PromoteAlloca: Refactor into analysis / commit phases (PR #170512)

[via llvm-commits]

Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/170512 at github.com>


================
@@ -1057,23 +1137,23 @@ bool AMDGPUPromoteAllocaImpl::tryPromoteAllocaToVector(AllocaInst &Alloca) {
 
   // Delete all instructions. On the first pass, new dummy loads may have been
   // added so we need to collect them too.
-  DenseSet<Instruction *> InstsToDelete(WorkList.begin(), WorkList.end());
+  DenseSet<Instruction *> InstsToDelete(AA.Vector.Worklist.begin(),
----------------
ruiling wrote:

The `InstsToDelete` is not necessary anymore since your last commit. And the comment is outed as well.

https://github.com/llvm/llvm-project/pull/170512