[llvm] [llvm-objdump] Support --mcpu=help/--mattr=help without -d (PR #165661)

[James Henderson via llvm-commits]

================
@@ -3533,6 +3533,33 @@ commaSeparatedValues(const llvm::opt::InputArgList &InputArgs, int ID) {
   return Values;
 }
 
+static void mcpuHelp() {
+  std::string Error;
+  Triple TheTriple;
+
+  if (!TripleName.empty()) {
+    TheTriple.setTriple(TripleName);
+  } else {
+    // We can guarantee that InputFilenames won't be empty.
+    Expected<OwningBinary<Binary>> OBinary = createBinary(InputFilenames[0]);
+    // OwningBinary<Binary> OBinary =
+    if (!OBinary)
+      reportError(InputFilenames[0],
+                  "A target triple was not specified and could "
----------------
jh7370 wrote:

Please review the coding standards for warnings and error messages and fix.

Further, this will result in an assertion under certain configurations, because you've thrown away the error text contained in the Expected. You should include the text of the error in this message.

https://github.com/llvm/llvm-project/pull/165661