[llvm] [BOLT][BTI] Add MCPlusBuilder::insertBTI (PR #167329)

[Gergely Bálint via llvm-commits]

================
@@ -198,6 +198,125 @@ TEST_P(MCPlusBuilderTester, AArch64_BTI) {
   ASSERT_TRUE(BC->MIB->isImplicitBTIC(*II));
 }
 
+TEST_P(MCPlusBuilderTester, AArch64_insertBTI_empty) {
+  if (GetParam() != Triple::aarch64)
+    GTEST_SKIP();
+  BinaryFunction *BF = BC->createInjectedBinaryFunction("BF", true);
+  std::unique_ptr<BinaryBasicBlock> BB = BF->createBasicBlock();
+  MCInst CallInst = MCInstBuilder(AArch64::BR).addReg(AArch64::X16);
+#ifndef NDEBUG
+  ASSERT_DEATH(BC->MIB->insertBTI(*BB, CallInst),
+               "insertBTI should only be called on non-empty BasicBlocks");
+#else
+  BC->MIB->insertBTI(*BB, CallInst);
+  ASSERT(BB->size() == 0);
+#endif
+}
----------------
bgergely0 wrote:

Couldn't repro this issue with an empty BB. 

I will remove this check, and allow adding a BTI to an empty BB. 

https://github.com/llvm/llvm-project/pull/167329