[llvm] [DWARFLinkerParallel] Add missing version string in producer (PR #158195)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 9 00:28:07 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-debuginfo
Author: Shatyuka (shatyuka)
<details>
<summary>Changes</summary>
Add missing LLVM version string to `DW_AT_producer` in `__artificial_type_unit`.
---
Full diff: https://github.com/llvm/llvm-project/pull/158195.diff
2 Files Affected:
- (modified) llvm/lib/DWARFLinker/Parallel/DWARFLinkerTypeUnit.cpp (+4-5)
- (modified) llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-uniquing.cpp (+9-9)
``````````diff
diff --git a/llvm/lib/DWARFLinker/Parallel/DWARFLinkerTypeUnit.cpp b/llvm/lib/DWARFLinker/Parallel/DWARFLinkerTypeUnit.cpp
index 07bbde70c77c4..534689e56851d 100644
--- a/llvm/lib/DWARFLinker/Parallel/DWARFLinkerTypeUnit.cpp
+++ b/llvm/lib/DWARFLinker/Parallel/DWARFLinkerTypeUnit.cpp
@@ -58,12 +58,11 @@ void TypeUnit::createDIETree(BumpPtrAllocator &Allocator) {
uint64_t OutOffset = getDebugInfoHeaderSize();
UnitDIE->setOffset(OutOffset);
- SmallString<200> ProducerString;
- ProducerString += "llvm DWARFLinkerParallel library version ";
+ const char *ProducerString =
+ "llvm DWARFLinkerParallel library version " LLVM_VERSION_STRING;
DebugInfoSection.notePatchWithOffsetUpdate(
- DebugStrPatch{
- {OutOffset},
- GlobalData.getStringPool().insert(ProducerString.str()).first},
+ DebugStrPatch{{OutOffset},
+ GlobalData.getStringPool().insert(ProducerString).first},
PatchesOffsets);
OutOffset += DIETreeGenerator
.addStringPlaceholderAttribute(dwarf::DW_AT_producer,
diff --git a/llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-uniquing.cpp b/llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-uniquing.cpp
index f156023fd0a95..e7c33b2a2c6a3 100644
--- a/llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-uniquing.cpp
+++ b/llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-uniquing.cpp
@@ -252,15 +252,15 @@ void foo() {
// CHECK:0x00000064: "u"
// CHECK:0x00000066: "AnonC"
// CHECK:0x0000006c: "(anonymous namespace)"
-// CHECK:0x00000082: "llvm DWARFLinkerParallel library version "
-// CHECK:0x000000ac: "__artificial_type_unit"
-// CHECK:0x000000c3: ""
-// CHECK:0x000000c4: "AliasForS"
-// CHECK:0x000000ce: "C"
-// CHECK:0x000000d0: "N"
-// CHECK:0x000000d2: "Nested"
-// CHECK:0x000000d9: "S"
-// CHECK:0x000000db: "U"
+// CHECK:0x00000082: "llvm DWARFLinkerParallel library version
+// CHECK: "__artificial_type_unit"
+// CHECK: ""
+// CHECK: "AliasForS"
+// CHECK: "C"
+// CHECK: "N"
+// CHECK: "Nested"
+// CHECK: "S"
+// CHECK: "U"
// CHECK:.apple_names
``````````
</details>
https://github.com/llvm/llvm-project/pull/158195
More information about the llvm-commits
mailing list