[llvm] SelectionDAG: Improve expandFMINIMUM_FMAXIMUM (PR #137367)

via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 8 22:09:28 PST 2025


github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 128438 tests passed
* 2793 tests skipped
* 2 tests failed

## Failed Tests
(click on a test name to see its output)

### LLVM
<details>
<summary>LLVM.CodeGen/AMDGPU/fcanonicalize-elimination.ll</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
c:\_work\llvm-project\llvm-project\build\bin\llc.exe -mtriple=amdgcn -mcpu=gfx801 -denormal-fp-math-f32=preserve-sign < C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fcanonicalize-elimination.ll | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe -enable-var-scope -check-prefixes=GCN,VI,VI-FLUSH,GCN-FLUSH C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fcanonicalize-elimination.ll
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\llc.exe' -mtriple=amdgcn -mcpu=gfx801 -denormal-fp-math-f32=preserve-sign
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' -enable-var-scope -check-prefixes=GCN,VI,VI-FLUSH,GCN-FLUSH 'C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fcanonicalize-elimination.ll'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fcanonicalize-elimination.ll:11:13: error: VI-LABEL: expected string not found in input
# | ; VI-LABEL: test_no_fold_canonicalize_loaded_value_f32:
# |             ^
# | <stdin>:16:44: note: scanning from here
# | test_no_fold_canonicalize_loaded_value_f32: ; @test_no_fold_canonicalize_loaded_value_f32
# |                                            ^
# | <stdin>:16:48: note: possible intended match here
# | test_no_fold_canonicalize_loaded_value_f32: ; @test_no_fold_canonicalize_loaded_value_f32
# |                                                ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fcanonicalize-elimination.ll
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |             .
# |             .
# |             .
# |            11:  .long 0 
# |            12:  .text 
# |            13:  .globl test_no_fold_canonicalize_loaded_value_f32 ; -- Begin function test_no_fold_canonicalize_loaded_value_f32 
# |            14:  .p2align 8 
# |            15:  .type test_no_fold_canonicalize_loaded_value_f32, at function 
# |            16: test_no_fold_canonicalize_loaded_value_f32: ; @test_no_fold_canonicalize_loaded_value_f32 
# | label:11'0                                                X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# | label:11'1                                                    ?                                           possible intended match
# |            17: ; %bb.0: 
# | label:11'0     ~~~~~~~~~
# |            18:  s_load_dwordx2 s[0:1], s[4:5], 0x24 
# | label:11'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            19:  v_lshlrev_b32_e32 v0, 2, v0 
# | label:11'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            20:  s_waitcnt lgkmcnt(0) 
# | label:11'0     ~~~~~~~~~~~~~~~~~~~~~~
# |            21:  v_mov_b32_e32 v1, s1 
# | label:11'0     ~~~~~~~~~~~~~~~~~~~~~~
# |             .
# |             .
# |             .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>LLVM.CodeGen/AMDGPU/fneg-combines.new.ll</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
c:\_work\llvm-project\llvm-project\build\bin\llc.exe -mtriple=amdgcn -mcpu=hawaii -mattr=+flat-for-global < C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe -enable-var-scope --check-prefixes=GCN,GCN-SAFE,SI,SI-SAFE C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\llc.exe' -mtriple=amdgcn -mcpu=hawaii -mattr=+flat-for-global
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' -enable-var-scope --check-prefixes=GCN,GCN-SAFE,SI,SI-SAFE 'C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll'
# note: command had no output on stdout or stderr
# RUN: at line 3
c:\_work\llvm-project\llvm-project\build\bin\llc.exe -enable-no-signed-zeros-fp-math -mtriple=amdgcn -mcpu=hawaii -mattr=+flat-for-global -fp-contract=fast < C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe -enable-var-scope --check-prefixes=GCN,GCN-NSZ,SI,SI-NSZ C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\llc.exe' -enable-no-signed-zeros-fp-math -mtriple=amdgcn -mcpu=hawaii -mattr=+flat-for-global -fp-contract=fast
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' -enable-var-scope --check-prefixes=GCN,GCN-NSZ,SI,SI-NSZ 'C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll'
# note: command had no output on stdout or stderr
# RUN: at line 5
c:\_work\llvm-project\llvm-project\build\bin\llc.exe -mtriple=amdgcn -mcpu=fiji < C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe -enable-var-scope --check-prefixes=GCN,GCN-SAFE,VI,VI-SAFE C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\llc.exe' -mtriple=amdgcn -mcpu=fiji
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' -enable-var-scope --check-prefixes=GCN,GCN-SAFE,VI,VI-SAFE 'C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll:4444:13: error: VI-LABEL: expected string not found in input
# | ; VI-LABEL: v_fmul_0_fsub_0_safe_infloop_regression:
# |             ^
# | <stdin>:10180:41: note: scanning from here
# | v_fmul_0_fsub_0_safe_infloop_regression: ; @v_fmul_0_fsub_0_safe_infloop_regression
# |                                         ^
# | <stdin>:10180:45: note: possible intended match here
# | v_fmul_0_fsub_0_safe_infloop_regression: ; @v_fmul_0_fsub_0_safe_infloop_regression
# |                                             ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\AMDGPU\fneg-combines.new.ll
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |               .
# |               .
# |               .
# |           10175:  .long 0 
# |           10176:  .text 
# |           10177:  .globl v_fmul_0_fsub_0_safe_infloop_regression ; -- Begin function v_fmul_0_fsub_0_safe_infloop_regression 
# |           10178:  .p2align 2 
# |           10179:  .type v_fmul_0_fsub_0_safe_infloop_regression, at function 
# |           10180: v_fmul_0_fsub_0_safe_infloop_regression: ; @v_fmul_0_fsub_0_safe_infloop_regression 
# | label:4444'0                                             X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# | label:4444'1                                                 ?                                        possible intended match
# |           10181: ; %bb.0: ; %bb 
# | label:4444'0     ~~~~~~~~~~~~~~~
# |           10182:  s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) 
# | label:4444'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           10183:  v_mul_f32_e32 v0, 0, v0 
# | label:4444'0     ~~~~~~~~~~~~~~~~~~~~~~~~~
# |           10184:  v_sub_f32_e32 v0, 0, v0 
# | label:4444'0     ~~~~~~~~~~~~~~~~~~~~~~~~~
# |           10185:  s_setpc_b64 s[30:31] 
# | label:4444'0     ~~~~~~~~~~~~~~~~~~~~~~
# |               .
# |               .
# |               .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/137367


More information about the llvm-commits mailing list