[llvm] [AMDGPU] Remove unused TableGen generated enum (PR #171170)
Mirko BrkuĊĦanin via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 8 10:10:54 PST 2025
https://github.com/mbrkusanin created https://github.com/llvm/llvm-project/pull/171170
This GenericEnum was just adding separate values for VOP3P_Pseudo opcodes
in the same namespace as existing opcodes that did not match. They were
defined in AMDGPUGenSearchableTables.inc by tablegen emitter but were
guarded out by #ifdef. Because of that, they were never included in the
code, so the compiler never reported the naming conflict and the bug never
had a chance to surface.
>From 6d3b91100bf75dd294707ce60a24b4c47d7d0708 Mon Sep 17 00:00:00 2001
From: Mirko Brkusanin <Mirko.Brkusanin at amd.com>
Date: Mon, 8 Dec 2025 19:07:53 +0100
Subject: [PATCH] [AMDGPU] Remove unused TableGen generated enum
This GenericEnum was just adding separate values for VOP3P_Pseudo opcodes
in the same namespace as existing opcodes that did not match. They were
defined in AMDGPUGenSearchableTables.inc by tablegen emitter but were
guarded out by #ifdef. Because of that, they were never included in the
code, so the compiler never reported the naming conflict and the bug never
had a chance to surface.
---
llvm/lib/Target/AMDGPU/VOP3PInstructions.td | 6 ------
1 file changed, 6 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/VOP3PInstructions.td b/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
index 786e75f081e44..2dfa905848a34 100644
--- a/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
+++ b/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
@@ -1364,16 +1364,10 @@ class WMMAOpcodeMapping<Instruction TwoAddr, Instruction ThreeAddr> {
field bit is_wmma_xdl;
}
-def WMMAOpcode : GenericEnum {
- let FilterClass = "VOP3P_Pseudo";
-}
-
class WMMAMappingTable : GenericTable {
let FilterClass = "WMMAOpcodeMapping";
let CppTypeName = "WMMAOpcodeMappingInfo";
let Fields = ["Opcode2Addr", "Opcode3Addr"];
- string TypeOf_Opcode2Addr = "WMMAOpcode";
- string TypeOf_Opcode3Addr = "WMMAOpcode";
}
def WMMAOpcode2AddrMappingTable : WMMAMappingTable {
More information about the llvm-commits
mailing list